Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ICE on non-ADT rcvr type when looking for crate version collision #129250

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Do not ICE on non-ADT rcvr type when looking for crate version collision #129250

merged 2 commits into from
Aug 27, 2024
+33 −23

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Aug 18, 2024 •
edited by matthiaskrgr
Loading

When looking for multiple versions of the same crate, do not blindly construct the receiver type.

Follow up to #128786.
Fixes #129205
Fixes #129216

@rustbot
Copy link
Collaborator

rustbot commented Aug 18, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 18, 2024
@Nadrieril
Copy link
Member

r? compiler

@rustbot rustbot assigned compiler-errors and unassigned Nadrieril Aug 19, 2024
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2024
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 21, 2024

📌 Commit c78e7fa has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 21, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 21, 2024
@tgross35
Rollup merge of rust-lang#129250 - estebank:issue-129205, r=compiler-…
aca99a2 
…errors

Do not ICE on non-ADT rcvr type when looking for crate version collision

When looking for multiple versions of the same crate, do not blindly construct the receiver type.

Follow up to rust-lang#128786. Fix rust-lang#129205.
@tgross35 tgross35 mentioned this pull request Aug 21, 2024
Closed
@jieyouxu
Copy link
Member

Failed in #129348 (comment)

[crashes] tests/crashes/129205.rs ... F
[crashes] tests/crashes/129216.rs ... F

Probably need to remove these tests or convert to ui tests.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 21, 2024
@jieyouxu
Copy link
Member

Maybe this PR also fixes #129216?

@gurry
Copy link
Contributor

gurry commented Aug 22, 2024

Maybe this PR also fixes #129216?

Yes, it should as the ICE in #129216 occurred inside the call to type_of and that call is removed now.

@compiler-errors compiler-errors mentioned this pull request Aug 26, 2024
Open
estebank and others added 2 commits August 26, 2024 13:02
@compiler-errors
Copy link
Member

compiler-errors commented Aug 26, 2024 •
edited
Loading

I've rebased and removed the offending crashes. I don't think needs more tests, since they're exercising the same codepath (param has no type_of). Pushing now because I believe that beta branches tomorrow, and I'd like to get this fix sooner than later.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 26, 2024

📌 Commit 4a088d9 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2024
@matthiaskrgr
Copy link
Member

(ive updated pr header to autotclose the other crashtest issue as well)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 26, 2024
@matthiaskrgr
Rollup merge of rust-lang#129250 - estebank:issue-129205, r=compiler-…
28c4516 
…errors

Do not ICE on non-ADT rcvr type when looking for crate version collision

When looking for multiple versions of the same crate, do not blindly construct the receiver type.

Follow up to rust-lang#128786.
Fixes rust-lang#129205
Fixes rust-lang#129216
This was referenced Aug 26, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 26, 2024
@bors
Auto merge of rust-lang#129632 - matthiaskrgr:rollup-8055gq6, r=matth…
bf662eb 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#126013 (Add `#[warn(unreachable_pub)]` to a bunch of compiler crates)
 - rust-lang#128157 (deduplicate and clarify rules for converting pointers to references)
 - rust-lang#129032 (Document & implement the transmutation modeled by `BikeshedIntrinsicFrom`)
 - rust-lang#129250 (Do not ICE on non-ADT rcvr type when looking for crate version collision)
 - rust-lang#129340 (Remove Duplicate E0381 Label)
 - rust-lang#129560 ([rustdoc] Generate source link on impl associated types)
 - rust-lang#129622 (Remove a couple of unused feature enables)
 - rust-lang#129625 (Rename `ParenthesizedGenericArgs` to `GenericArgsMode`)
 - rust-lang#129626 (Remove `ParamMode::ExplicitNamed`)

Failed merges:

 - rust-lang#128166 (Improved `checked_isqrt` and `isqrt` methods)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d4d4b6b into rust-lang:master Aug 27, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2024
@rust-timer
Unrolled build for rust-lang#129250
ce0ce84 
Rollup merge of rust-lang#129250 - estebank:issue-129205, r=compiler-errors

Do not ICE on non-ADT rcvr type when looking for crate version collision

When looking for multiple versions of the same crate, do not blindly construct the receiver type.

Follow up to rust-lang#128786.
Fixes rust-lang#129205
Fixes rust-lang#129216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

@compiler-errors compiler-errors compiler-errors requested changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

ICE: associated type missing default ICE: unexpected non-type Node::GenericParam
9 participants
@estebank @rustbot @Nadrieril @compiler-errors @bors @rust-log-analyzer @jieyouxu @gurry @matthiaskrgr