Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LLVM 19 rc 3 #129303

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Update to LLVM 19 rc 3 #129303

merged 1 commit into from
Aug 24, 2024

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Aug 20, 2024

I don't think that this fixes any specific issues we've encountered.

@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2024
@cuviper
Copy link
Member

cuviper commented Aug 20, 2024

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Aug 20, 2024

📌 Commit 3f5c222 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2024
@bors
Copy link
Contributor

bors commented Aug 22, 2024

⌛ Testing commit 3f5c222 with merge 74fc91b...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 22, 2024
Update to LLVM 19 rc 3

I don't think that this fixes any specific issues we've encountered.
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] miri test:false 4.481
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Thu, Aug 22, 2024  5:15:20 AM
  network time: Thu, 22 Aug 2024 05:15:20 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@matthiaskrgr
Copy link
Member

@bors retry

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2024
Update to LLVM 19 rc 3

I don't think that this fixes any specific issues we've encountered.
@bors
Copy link
Contributor

bors commented Aug 23, 2024

⌛ Testing commit 3f5c222 with merge c151204...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] miri test:false 4.486
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Fri, Aug 23, 2024  5:13:48 AM
  network time: Fri, 23 Aug 2024 05:13:49 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Contributor

bors commented Aug 23, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 23, 2024
@tgross35
Copy link
Contributor

tgross35 commented Aug 23, 2024

@bors retry, #127883 again

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2024
@bors
Copy link
Contributor

bors commented Aug 24, 2024

⌛ Testing commit 3f5c222 with merge edbc000...

@bors
Copy link
Contributor

bors commented Aug 24, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing edbc000 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 24, 2024
@bors bors merged commit edbc000 into rust-lang:master Aug 24, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 24, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (edbc000): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 1.2%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)
3.1% [2.2%, 3.8%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.449s -> 750.628s (-0.11%)
Artifact size: 339.00 MiB -> 338.92 MiB (-0.02%)

@jieyouxu jieyouxu added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-spurious-fail-msvc CI spurious failure: target env msvc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants