Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force LC_ALL=C for all run-make tests #129363

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Aug 21, 2024

This PR adds LC_ALL=C for all run-make tests so that they become locale independent.

Fixes #129362
r? @jieyouxu

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2024

The run-make-support library was changed

cc @jieyouxu

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick patch. Feel free to r=me after CI is green.

@Urgau
Copy link
Member Author

Urgau commented Aug 21, 2024

@bors r=@jieyouxu rollup

@bors
Copy link
Contributor

bors commented Aug 21, 2024

📌 Commit b6909ce has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#128727 (bump conflicting_repr_hints lint to be shown in dependencies)
 - rust-lang#129232 (Fix `thread::sleep` Duration-handling for ESP-IDF)
 - rust-lang#129321 (Change neutral element of <fNN as iter::Sum> to neg_zero)
 - rust-lang#129353 (llvm-wrapper: adapt for LLVM 20 API changes)
 - rust-lang#129363 (Force `LC_ALL=C` for all run-make tests)
 - rust-lang#129364 (safe transmute: gracefully bubble-up layout errors)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 92f0b7e into rust-lang:master Aug 21, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2024
Rollup merge of rust-lang#129363 - Urgau:run-make-lc_all-c, r=jieyouxu

Force `LC_ALL=C` for all run-make tests

This PR adds `LC_ALL=C` for all run-make tests so that they become locale independent.

Fixes rust-lang#129362
r? `@jieyouxu`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

dylib-soname run-make test is not language independant
4 participants