Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f16 and f128 inline ASM support for aarch64 #129536

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

beetrees
Copy link
Contributor

@beetrees beetrees commented Aug 24, 2024

Adds f16 and f128 inline ASM support for aarch64. SIMD vector types are taken from the ARM intrinsics list. Based on the work of @lengrongfu in #127043.

Relevant issue: #125398
Tracking issue: #116909

@rustbot label +F-f16_and_f128

try-job: aarch64-gnu
try-job: aarch64-apple

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` labels Aug 24, 2024
@tgross35
Copy link
Contributor

tgross35 commented Aug 25, 2024

Thanks for getting this over the line, and thanks @lengrongfu for getting this started.

r? @Amanieu from the other asm changes

@rustbot rustbot assigned Amanieu and unassigned davidtwco Aug 25, 2024
@Amanieu
Copy link
Member

Amanieu commented Aug 26, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2024

📌 Commit abd44fc has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2024
@tgross35
Copy link
Contributor

There are at least a few jobs in the queue before this will get picked up. Might as well use that time to verify the tests here.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2024
@tgross35
Copy link
Contributor

@bors try

@bors
Copy link
Contributor

bors commented Aug 27, 2024

⌛ Trying commit abd44fc with merge e6fadc6...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2024
…, r=<try>

Add `f16` and `f128` inline ASM support for `aarch64`

Adds `f16` and `f128` inline ASM support for `aarch64`. SIMD vector types are taken from [the ARM intrinsics list](https://developer.arm.com/architectures/instruction-sets/intrinsics/#f:`@navigationhierarchiesreturnbasetype=[float]&f:@navigationhierarchieselementbitsize=[16]&f:@navigationhierarchiesarchitectures=[A64]).` Based on the work of `@lengrongfu` in rust-lang#127043.

Relevant issue: rust-lang#125398
Tracking issue: rust-lang#116909

`@rustbot` label +F-f16_and_f128

try-job: aarch64-gnu
try-job: aarch64-apple
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Updating files:  98% (48254/49238)
Updating files:  99% (48746/49238)
Updating files: 100% (49238/49238)
Updating files: 100% (49238/49238), done.
Switched to a new branch 'try'
branch 'try' set up to track 'origin/try'.
[command]/opt/homebrew/bin/git log -1 --format='%H'
'e6fadc641686689bc944772b2687b843130a8680'
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
file:.git/config submodule.library/stdarch.url=https://github.com/rust-lang/stdarch.git
file:.git/config submodule.src/doc/book.active=true
---
fmt check
fmt: skipped untracked file AWSCLIV2.pkg
fmt: checked 5511 files
tidy check
thread 'deps (.)' panicked at src/tools/tidy/src/deps.rs:587:24:
cmd.exec() failed with `cargo metadata` exited with an error:     Updating crates.io index
warning: spurious network error (3 tries remaining): unexpected http status code: 429; class=Http (34)
warning: spurious network error (2 tries remaining): unexpected http status code: 429; class=Http (34)
warning: spurious network error (1 tries remaining): unexpected http status code: 429; class=Http (34)
warning: spurious network error (1 tries remaining): unexpected http status code: 429; class=Http (34)
error: failed to get `rust_team_data` as a dependency of package `site v0.1.0 (/Users/runner/work/rust/rust/src/tools/rustc-perf/site)`
Caused by:
  failed to load source for dependency `rust_team_data`

Caused by:
Caused by:
  Unable to update https://github.com/rust-lang/team#a5260e76

Caused by:
  failed to clone into: /Users/runner/.cargo/git/db/team-8b970833d5192347
Caused by:
  network failure seems to have happened
  if a proxy or similar is necessary `net.git-fetch-with-cli` may help here
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

Caused by:
  unexpected http status code: 429; class=Http (34)

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at src/tools/tidy/src/main.rs:60:49:
called `Result::unwrap()` on an `Err` value: Any { .. }
Command has failed. Rerun with -v to see more details.
  local time: Tue Aug 27 04:59:03 UTC 2024
  network time: Tue, 27 Aug 2024 04:59:03 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Contributor

bors commented Aug 27, 2024

💔 Test failed - checks-actions

@tgross35
Copy link
Contributor

@bors try network failure

@bors
Copy link
Contributor

bors commented Aug 27, 2024

⌛ Trying commit abd44fc with merge 2e5b402...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2024
…, r=<try>

Add `f16` and `f128` inline ASM support for `aarch64`

Adds `f16` and `f128` inline ASM support for `aarch64`. SIMD vector types are taken from [the ARM intrinsics list](https://developer.arm.com/architectures/instruction-sets/intrinsics/#f:`@navigationhierarchiesreturnbasetype=[float]&f:@navigationhierarchieselementbitsize=[16]&f:@navigationhierarchiesarchitectures=[A64]).` Based on the work of `@lengrongfu` in rust-lang#127043.

Relevant issue: rust-lang#125398
Tracking issue: rust-lang#116909

`@rustbot` label +F-f16_and_f128

try-job: aarch64-gnu
try-job: aarch64-apple
@bors
Copy link
Contributor

bors commented Aug 27, 2024

☀️ Try build successful - checks-actions
Build commit: 2e5b402 (2e5b402ee6c393514d53db5991da504f22dcd2a6)

@tgross35
Copy link
Contributor

@bors r=Amanieu

@bors
Copy link
Contributor

bors commented Aug 27, 2024

📌 Commit abd44fc has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2024
Rollup of 9 pull requests

Successful merges:

 - rust-lang#126985 (Implement `-Z embed-source` (DWARFv5 source code embedding extension))
 - rust-lang#127922 (Add unsafe to extern blocks in style guide)
 - rust-lang#128731 (simd_shuffle intrinsic: allow argument to be passed as vector)
 - rust-lang#128935 (More work on `zstd` compression)
 - rust-lang#128942 (miri weak memory emulation: put previous value into initial store buffer)
 - rust-lang#129418 (rustc: Simplify getting sysroot library directory)
 - rust-lang#129490 (Add Trusty OS as tier 3 target)
 - rust-lang#129536 (Add `f16` and `f128` inline ASM support for `aarch64`)
 - rust-lang#129559 (float types: document NaN bit pattern guarantees)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8ea70e9 into rust-lang:master Aug 27, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2024
Rollup merge of rust-lang#129536 - beetrees:f16-f128-inline-asm-aarch64, r=Amanieu

Add `f16` and `f128` inline ASM support for `aarch64`

Adds `f16` and `f128` inline ASM support for `aarch64`. SIMD vector types are taken from [the ARM intrinsics list](https://developer.arm.com/architectures/instruction-sets/intrinsics/#f:`@navigationhierarchiesreturnbasetype=[float]&f:@navigationhierarchieselementbitsize=[16]&f:@navigationhierarchiesarchitectures=[A64]).` Based on the work of `@lengrongfu` in rust-lang#127043.

Relevant issue: rust-lang#125398
Tracking issue: rust-lang#116909

`@rustbot` label +F-f16_and_f128

try-job: aarch64-gnu
try-job: aarch64-apple
@beetrees beetrees deleted the f16-f128-inline-asm-aarch64 branch August 27, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants