Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stacker to 0.1.17 #129619

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Update stacker to 0.1.17 #129619

merged 1 commit into from
Sep 1, 2024

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Aug 26, 2024 •
edited by tgross35
Loading

The main new feature is support for detecting the current stack size on illumos. (See my blog post for the context which led to this.)

try-job: x86_64-mingw

@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@tgross35
Copy link
Contributor

tgross35 commented Aug 26, 2024 •
edited
Loading

I originally had this update in #129624 and tried it there, but I think the old version of windows-sys that gets pulled in breaks things.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 26, 2024
@bors
Auto merge of rust-lang#129619 - sunshowers:update-stacker, r=<try>
17b491d 
Update stacker to 0.1.16

The main new feature is support for detecting the current stack size on illumos. (See [my blog post] for the context which led to this.)

[my blog post]: https://sunshowers.io/posts/rustc-segfault-illumos/

try-job: x86_64-mingw
@bors
Copy link
Contributor

bors commented Aug 26, 2024

⌛ Trying commit eb29722 with merge 17b491d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 26, 2024
@bors
Auto merge of rust-lang#129619 - sunshowers:update-stacker, r=<try>
8cbd51c 
Update stacker to 0.1.16

The main new feature is support for detecting the current stack size on illumos. (See [my blog post] for the context which led to this.)

[my blog post]: https://sunshowers.io/posts/rustc-segfault-illumos/

try-job: x86_64-mingw
@bors
Copy link
Contributor

bors commented Aug 26, 2024

⌛ Trying commit eb29722 with merge 8cbd51c...

@sunshowers
Copy link
Contributor Author

I originally had this update in #129624 and tried it there, but I think the old version of windows-sys that gets pulled in breaks things.

@bors try

hmm, yeah I did notice the old version of windows-sys -- should we just update that in stacker?

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Aug 26, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2024
@tgross35
Copy link
Contributor

hmm, yeah I did notice the old version of windows-sys -- should we just update that in stacker?

That is probably worth trying, as long as there isn't a specific reason to keep the old version

@sunshowers
Copy link
Contributor Author

Ah I guess this is blocked on rust-lang/stacker#94 then.

@sunshowers sunshowers marked this pull request as draft August 26, 2024 23:34
@tgross35
Copy link
Contributor

Ah, yeah. Ugh.

@rustbot blocked

@rustbot rustbot added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2024
@djc
Copy link
Contributor

djc commented Aug 27, 2024

(0.1.17 was released already.)

@sunshowers
Update stacker to 0.1.17
ea6df5c 
The main new feature is support for detecting the current stack size on
illumos. (See my blog post [1] for the context which led to this.)

[1]: https://sunshowers.io/posts/rustc-segfault-illumos/
@sunshowers
Copy link
Contributor Author

@rustbot label -S-blocked +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Aug 28, 2024
@sunshowers sunshowers changed the title Update stacker to 0.1.16 Update stacker to 0.1.17 Aug 28, 2024
@sunshowers sunshowers marked this pull request as ready for review August 28, 2024 22:03
@sunshowers
Copy link
Contributor Author

All right, updated to 0.1.17 (which has a pleasingly small diff to Cargo.lock).

@tgross35
Copy link
Contributor

@bors try

@bors
Copy link
Contributor

bors commented Aug 28, 2024

⌛ Trying commit ea6df5c with merge eb29255...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2024
@bors
Auto merge of rust-lang#129619 - sunshowers:update-stacker, r=<try>
eb29255 
Update stacker to 0.1.17

The main new feature is support for detecting the current stack size on illumos. (See [my blog post] for the context which led to this.)

[my blog post]: https://sunshowers.io/posts/rustc-segfault-illumos/

try-job: x86_64-mingw
@bors
Copy link
Contributor

bors commented Aug 29, 2024

☀️ Try build successful - checks-actions
Build commit: eb29255 (eb29255203a170bce0e2e33724eff0d37016716f)

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 31, 2024

📌 Commit ea6df5c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2024
@tgross35 tgross35 mentioned this pull request Aug 31, 2024
Open
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 1, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2024
@bors
Auto merge of rust-lang#129841 - matthiaskrgr:rollup-pkavdtl, r=matth…
78d5c04 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128495 (core: use `compare_bytes` for more slice element types)
 - rust-lang#128641 (refactor: standardize duplicate processes in parser)
 - rust-lang#129207 (Lint that warns when an elided lifetime ends up being a named lifetime)
 - rust-lang#129493 (Create opaque definitions in resolver.)
 - rust-lang#129619 (Update stacker to 0.1.17)
 - rust-lang#129672 (Make option-like-enum.rs UB-free and portable)
 - rust-lang#129780 (add crashtests for several old unfixed ICEs)
 - rust-lang#129832 (Remove stray dot in `std::char::from_u32_unchecked` documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 62b8fdb into rust-lang:master Sep 1, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Sep 1, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2024
@rust-timer
Unrolled build for rust-lang#129619
eceab25 
Rollup merge of rust-lang#129619 - sunshowers:update-stacker, r=Mark-Simulacrum

Update stacker to 0.1.17

The main new feature is support for detecting the current stack size on illumos. (See [my blog post] for the context which led to this.)

[my blog post]: https://sunshowers.io/posts/rustc-segfault-illumos/

try-job: x86_64-mingw
@cuviper cuviper modified the milestones: 1.82.0, 1.83.0 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
8 participants
@sunshowers @rustbot @tgross35 @bors @rust-log-analyzer @djc @Mark-Simulacrum @cuviper