Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Guard Patterns down to THIR #129996

Closed
wants to merge 16 commits into from
Closed

Implement Guard Patterns down to THIR #129996

wants to merge 16 commits into from

Conversation

max-niederman
Copy link
Contributor

@max-niederman max-niederman commented Sep 5, 2024 •
edited
Loading

Partial implementation of RFC 3637 including parsing, HIR lowering, and THIR lowering but not MIR lowering or anything depending on it.

See the tracking issue for more info.

@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 5, 2024
@max-niederman
Copy link
Contributor Author

@rustbot label +S-waiting-on-author -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 19, 2024

☔ The latest upstream changes (presumably #123877) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 23, 2024

☔ The latest upstream changes (presumably #130724) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Oct 16, 2024

☔ The latest upstream changes (presumably #131792) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot self-assigned this Oct 17, 2024
@nnethercote nnethercote removed their assignment Oct 30, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@max-niederman max-niederman changed the title Implement Guard Patterns Implement Guard Patterns down to THIR Oct 30, 2024
@max-niederman max-niederman marked this pull request as ready for review October 30, 2024 07:10
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@max-niederman
Copy link
Contributor Author

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2024
@bors
Copy link
Contributor

bors commented Oct 30, 2024

☔ The latest upstream changes (presumably #132349) made this pull request unmergeable. Please resolve the merge conflicts.

@Nadrieril
Copy link
Member

I believe this is waiting on you fixing the merge conflicts. If you want to make reviewing easier you could also split it in a few PRs, e.g. one PR with just the parsing and a separate one for the THIR changes.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2024
@max-niederman
Copy link
Contributor Author

I unfortunately don't really have time to work on this anymore, so I'll be closing this at least for the foreseeable future.

This was referenced Nov 24, 2024
Open
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#133424 - Nadrieril:guard-patterns-parsing, …
1868c8f 
…r=fee1-dead

Parse guard patterns

This implements the parsing of [RFC3637 Guard Patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see also [tracking issue](rust-lang#129967)). This PR is extracted from rust-lang#129996 with minor modifications.

cc `@max-niederman`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024
@rust-timer
Unrolled build for rust-lang#133424
2bad485 
Rollup merge of rust-lang#133424 - Nadrieril:guard-patterns-parsing, r=fee1-dead

Parse guard patterns

This implements the parsing of [RFC3637 Guard Patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see also [tracking issue](rust-lang#129967)). This PR is extracted from rust-lang#129996 with minor modifications.

cc `@max-niederman`
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Dec 15, 2024
@matthiaskrgr
Rollup merge of #133424 - Nadrieril:guard-patterns-parsing, r=fee1-dead
24ccb15 
Parse guard patterns

This implements the parsing of [RFC3637 Guard Patterns](https://rust-lang.github.io/rfcs/3637-guard-patterns.html) (see also [tracking issue](rust-lang/rust#129967)). This PR is extracted from rust-lang/rust#129996 with minor modifications.

cc `@max-niederman`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@max-niederman @rustbot @rust-log-analyzer @bors @Nadrieril @cjgillot @nnethercote