bootstrap: add rust.std-features config
#130241
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
shrirambalaji
force-pushed
the
issue-129599-fix
branch
from
c724ebf
to
fa07dcf
Compare
|
r? onur-ozkan |
onur-ozkan
added
S-waiting-on-author
shrirambalaji
changed the title
std_features config to rust sectionstd_features config
shrirambalaji
force-pushed
the
issue-129599-fix
branch
from
073a143
to
fd3bcaa
Compare
shrirambalaji
changed the title
std_features configstd_features config
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
|
@rustbot review |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
onur-ozkan
added
S-waiting-on-author
Fix references to a nonexistent `consume` function in the doc comments for `Peekable::next_if` and `Peekable::next_if_eq`.
The optimized clone method ends up as the following MIR:
```
_2 = copy ((*_1).0: i32);
_3 = copy ((*_1).1: u64);
_4 = copy ((*_1).2: [i8; 3]);
_0 = Foo { a: move _2, b: move _3, c: move _4 };
```
We can transform this to:
```
_0 = copy (*_1);
```
By moving `block_on` to an auxiliary crate, we avoid having to keep a separate copy of it in every async test. (This also incorporates some small tweaks to the headers in `await_ready.rs`.)
This does change the external interface, but not in a way that will cause any breakage because external users don't mention the lifetimes.
Giving them more typical names.
- Replace non-standard names like 's, 'p, 'rg, 'ck, 'parent, 'this, and 'me with vanilla 'a. These are cases where the original name isn't really any more informative than 'a. - Replace names like 'cx, 'mir, and 'body with vanilla 'a when the lifetime applies to multiple fields and so the original lifetime name isn't really accurate. - Put 'tcx last in lifetime lists, and 'a before 'b.
Failing to do this results in the lint example output complaining about the lint not existing instead of the thing the lint is supposed to be complaining about.
bootstrap: add std_features to config.example fix: use BTreeSet for std-features; add unit tests * fix formatting of string in front of std_features * rename `std_features` to `std-features` in config.toml fix: remove space before std-features in config.toml fix: remove explicit .into_iter conversion bootstrap: add details for rust.std-features in config.example.toml Co-authored-by: Onur Özkan <onurozkan.dev@outlook.com> fix: remove `Option<T>` from `rust_std_features` fix: move default rust_std_features to config fix: make std_features CI rustc incompatible
shrirambalaji
force-pushed
the
issue-129599-fix
branch
from
0a736eb
to
901aa18
Compare
|
Some changes occurred in match checking cc @Nadrieril Some changes occurred in coverage tests. cc @Zalathar
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred in coverage instrumentation. cc @Zalathar This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead. cc @calebzulawski, @programmerjake Some changes occurred in src/tools/opt-dist cc @Kobzol Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 These commits modify the If this was unintentional then you should revert the changes before this PR is merged. The Miri subtree was changed cc @rust-lang/miri changes to the core type system This PR modifies If appropriate, please update This PR modifies cc @jieyouxu Some changes occurred in src/tools/compiletest cc @jieyouxu Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred in compiler/rustc_sanitizers cc @rust-lang/project-exploit-mitigations, @rcvalle Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt These commits modify compiler targets. This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras The run-make-support library was changed cc @jieyouxu Some changes occurred to the platform-builtins intrinsics. Make sure the cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi Some changes occurred in engine.rs, potentially modifying the public API of HIR ty lowering was modified cc @fmease |
|
seemed to have botched the squash :/ |
Adding support for a
std-featuresconfig under therustsection inconfig.tomlduring bootstrap. This allows rustc devs to build with specific feature flags for local development.Fixes #129599