Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #130253

Merged
merged 27 commits into from
Sep 12, 2024
Merged

Rollup of 10 pull requests #130253

merged 27 commits into from
Sep 12, 2024

Commits on Sep 8, 2024

  1. Fix linking error when compiling for 32-bit watchOS

    In rust-lang#124748, I mistakenly conflated
    "not SjLj" to mean "ARM EHABI", which isn't true, watchOS armv7k
    (specifically only that architecture) uses a third unwinding method
    called "DWARF CFI".
    madsmtm committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    f98ca32 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    0b20ffc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f1e1be View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a0a89e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    180eace View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c40ee79 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3daa951 View commit details
    Browse the repository at this point in the history
  4. clean up internal comments about float semantics

    - remove an outdated FIXME
    - add reference to floating-point semantics issue
    
    Co-authored-by: Jubilee <workingjubilee@gmail.com>
    RalfJung and workingjubilee committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e556c13 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. update stdarch

    RalfJung committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b44f1dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    542a6c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db40dc3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b7be14 View commit details
    Browse the repository at this point in the history
  5. docs: remove struct info

    juliusl committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6c84238 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3842ea6 View commit details
    Browse the repository at this point in the history
  7. chore: remove struct details

    juliusl committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5527076 View commit details
    Browse the repository at this point in the history
  8. Use the same span for attributes and Try expansion of ?

    This is needed for Clippy to know that the `#[allow(unused)]` attributes
    added by the expansion of `?` are part of the desugaring, and that they
    do not come from the user code.
    
    rust-lang/rust-clippy#13380 exhibits a manifestation of this problem.
    samueltardieu committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6ee87ae View commit details
    Browse the repository at this point in the history
  9. Limit libc::link usage to nto70 target only, not NTO OS

    It seems QNX 7.0 does not support `linkat` at all (most tests were failing). Limiting to QNX 7.0 only, while using `linkat` for the future versions seems like the right path forward (tested on 7.0).
    
    Fixes 129895
    nyurik committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    368231c View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#129103 - Nadrieril:dont-warn-empty-unreacha…

    …ble, r=compiler-errors
    
    Don't warn empty branches unreachable for now
    
    The [stabilization](rust-lang#122792) of `min_exhaustive_patterns` updated the `unreachable_pattern` lint to trigger on empty arms too. This has caused some amount of churn, and imposes an unjoyful `#[allow(unreachable_patterns)]` onto library authors who want to stay backwards-compatible.
    
    While I think the lint should eventually cover these cases, for transition's sake I'd prefer to revert linting to what it was prior to stabilization, at least for now.
    
    Fixes rust-lang#129031.
    
    r? ``@compiler-errors``
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6879ee6 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#129696 - RalfJung:stdarch, r=Amanieu

    update stdarch
    
    The goal is mostly to pull in rust-lang/stdarch#1633.
    
    r? ```@Amanieu```
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    abf0ac5 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#129835 - RalfJung:float-tests, r=workingjub…

    …ilee
    
    enable const-float-classify test, and test_next_up/down on 32bit x86
    
    The  test_next_up/down tests have been disabled on all 32bit x86 targets, which goes too far -- they should definitely work on our (tier 1) i686 target, it is only without SSE that we might run into trouble due to rust-lang#114479. However, I cannot reproduce that trouble any more -- maybe that got fixed by rust-lang#123351?
    
    The  const-float-classify test relied on const traits "because we can", and got disabled when const traits got removed. That's an unfortunate reduction in test coverage of our float functionality, so let's restore the test in a way that does not rely on const traits.
    
    The const-float tests are actually testing runtime behavior as well, and I don't think that runtime behavior is covered anywhere else. Probably they shouldn't be called "const-float", but we don't have a `tests/ui/float` folder... should I create one and move them there? Are there any other ui tests that should be moved there?
    
    I also removed some FIXME referring to not use x87 for Rust-to-Rust-calls -- that has happened in rust-lang#123351 so this got fixed indeed. Does that mean we can simplify all that float code again? I am not sure how to test it. Is running the test suite with an i586 target enough?
    
    Cc ```@tgross35``` ```@workingjubilee```
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    312b597 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#130077 - madsmtm:watchos-arm-unwind, r=work…

    …ingjubilee
    
    Fix linking error when compiling for 32-bit watchOS
    
    In rust-lang#124494 (or rust-lang#124748), I mistakenly conflated "not SjLj" to mean "ARM EHABI", which isn't true, 32-bit watchOS uses a third unwinding method called "DWARF CFI".
    
    So this PR is effectively a revert of rust-lang#124494, with a few more comments explaining what's going on.
    
    Fixes rust-lang#130071.
    
    r? Mark-Simulacrum (since you reviewed the original)
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c4488c4 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#130114 - eduardosm:needless-returns, r=comp…

    …iler-errors
    
    Remove needless returns detected by clippy in the compiler
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a31a8fe View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#130168 - juliusl:pr/fix-win-fs-change-time-…

    …links, r=ChrisDenton
    
    maint: update docs for change_time ext and doc links
    
    maint: update docs for change_time ext and doc links
    
    Related: rust-lang#121478
    r? tgross35
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    eb9a4f7 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#130228 - RalfJung:intrinsics-notify, r=saet…

    …hlin
    
    notify Miri when intrinsics are changed
    
    `@rust-lang/miri` should we notify the entire team, or should I just add myself?
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1e3d1ad View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#130239 - RalfJung:miri-ptr-offset-unsigned,…

    … r=compiler-errors
    
    miri: fix overflow detection for unsigned pointer offset
    
    This is the Miri part of rust-lang#130229. This is already UB in codegen so we better make Miri detect it; updating the docs may take time if we have to follow some approval process, but let's make Miri match reality ASAP.
    
    r? ``@scottmcm``
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1425982 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#130244 - samueltardieu:qmark-expansion-span…

    …-fix, r=jieyouxu
    
    Use the same span for attributes and Try expansion of ?
    
    This is needed for Clippy to know that the `#[allow(unused)]` attributes added by the expansion of `?` are part of the desugaring, and that they do not come from the user code.
    
    rust-lang/rust-clippy#13380 exhibits a manifestation of this problem and will be fixed by this change.
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8265506 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#130248 - nyurik:fix-129895, r=workingjubilee

    Limit `libc::link` usage to `nto70` target only, not NTO OS
    
    It seems QNX 7.0 does not support `linkat` at all (most tests were failing). Limiting to QNX 7.0 only, while using `linkat` for the future versions seems like the right path forward (tested on 7.0).
    
    Fixes rust-lang#129895
    
    CC: `@japaric` `@flba-eb` `@saethlin`
    workingjubilee authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b4201d3 View commit details
    Browse the repository at this point in the history