-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #130040 - unify llvm-bitcode-linker, wasm-component-ld and llvm-tools logics #130292
Conversation
r? @onur-ozkan rustbot has assigned @onur-ozkan. Use |
@bors r+ p=1 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d0985bb): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -1.9%, secondary 3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 759.189s -> 756.26s (-0.39%) |
…bzol add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot rust-lang#130040 is [reverted](rust-lang#130292) because adding component binaries directly to the dist tarball of the compiler caused conflicts (see rust-lang#130291 and rust-lang/rustup#4019). This PR solves the original problem without touching the dist tarball. r? Kobzol
Rollup merge of rust-lang#130302 - onur-ozkan:130040-with-fixes, r=Kobzol add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot rust-lang#130040 is [reverted](rust-lang#130292) because adding component binaries directly to the dist tarball of the compiler caused conflicts (see rust-lang#130291 and rust-lang/rustup#4019). This PR solves the original problem without touching the dist tarball. r? Kobzol
This is a revert of #130040 to fix #130291 which is preventing installing nightly with the llvm-tools component due to a conflict with the
bin/llc
file which exists in both the rustc and llvm-tools components.