Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Apple linker args from rustc_target to rustc_codegen_ssa #130435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Sep 16, 2024

They are dependent on the deployment target and SDK version, but having these in rustc_target makes it hard to introduce that dependency. Part of the work needed to do #118204, see #129342 for some discussion.

Tested using:

./x test tests/run-make/apple-deployment-target --target="aarch64-apple-darwin,aarch64-apple-ios,aarch64-apple-ios-macabi,aarch64-apple-ios-sim,aarch64-apple-tvos,aarch64-apple-tvos-sim,aarch64-apple-visionos,aarch64-apple-visionos-sim,aarch64-apple-watchos,aarch64-apple-watchos-sim,arm64_32-apple-watchos,armv7k-apple-watchos,armv7s-apple-ios,x86_64-apple-darwin,x86_64-apple-ios,x86_64-apple-ios-macabi,x86_64-apple-tvos,x86_64-apple-watchos-sim,x86_64h-apple-darwin"
IPHONEOS_DEPLOYMENT_TARGET=10.0 ./x test tests/run-make/apple-deployment-target --target=i386-apple-ios

arm64e-apple-darwin and arm64e-apple-ios have not been tested, see #130085, neither is i686-apple-darwin, since that requires using an x86_64 macbook, and I currently can't get mine to work, see #130434.

CC @petrochenkov

They are dependent on the deployment target and SDK version, but having
these in `rustc_target` makes it hard to introduce that dependency.
@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2024

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@petrochenkov petrochenkov self-assigned this Sep 16, 2024
@arttet
Copy link
Contributor

arttet commented Sep 16, 2024

Hey @madsmtm,

I will appreciate it if you test arm64e-apple-darwin and arm64e-apple-ios. Here is a fix for arm64e-apple-darwin. Today, I have built arm64e-apple-ios successfully for 15.2 Xcode on macOS 13.

@madsmtm
Copy link
Contributor Author

madsmtm commented Sep 16, 2024

Hey @madsmtm,

I will appreciate it if you test arm64e-apple-darwin and arm64e-apple-ios. Here is a fix for arm64e-apple-darwin. Today, I have built arm64e-apple-ios successfully for 15.2 Xcode on macOS 13.

Nice! I will in the future once that lands (though it shouldn't block this and other PRs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants