Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 2 pull requests #130492

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Rollup of 2 pull requests #130492

merged 4 commits into from
Sep 18, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

spastorino and others added 4 commits September 17, 2024 15:45
@spastorino
Remove redundant test typeid equality by subtyping
65f8999
@krtab
Remove uneeded PartialOrd bound in cmp::Ord::clamp
0c9a176 
There is a Self: PartialOrd bound in Ord::clamp, but it is already
required by the trait itself. Likely a left-over from the const trait
deletion in 76dbe29.

Reported-by: @noeensarguet
@matthiaskrgr
Rollup merge of rust-lang#130481 - krtab:clamp_partial_ord, r=cuviper
0a35418 
Remove uneeded PartialOrd bound in cmp::Ord::clamp

There is a `Self: PartialOrd` bound in `Ord::clamp`, but it is already required by the trait itself. Likely a left-over from the const trait deletion in 76dbe29.

Reported-by: `@noeensarguet`
@matthiaskrgr
Rollup merge of rust-lang#130482 - spastorino:remove-known-bug-97156,…
7e8eb7a 
… r=jackh726

Remove redundant test typeid equality by subtyping

This known-bug label was a left over on rust-lang#118247

r? `@jackh726`

This doesn't address rust-lang#110395, I didn't investigate about it yet.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 17, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=2

@bors
Copy link
Contributor

bors commented Sep 17, 2024

📌 Commit 7e8eb7a has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2024
@bors
Copy link
Contributor

bors commented Sep 17, 2024

⌛ Testing commit 7e8eb7a with merge f7b4c72...

@bors
Copy link
Contributor

bors commented Sep 18, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing f7b4c72 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2024
@bors bors merged commit f7b4c72 into rust-lang:master Sep 18, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 18, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#130481 Remove uneeded PartialOrd bound in cmp::Ord::clamp 5738000d9bb45bec7b8b044c1b175637dd1a1b6c (link)
#130482 Remove redundant test typeid equality by subtyping fce20e89651122c31cd96440a220c6f79f6044be (link)

previous master: 28e8f01c2a

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors mentioned this pull request Sep 18, 2024
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f7b4c72): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.6% [-1.8%, -1.5%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.6% [-1.8%, -1.5%] 2

Cycles

Results (secondary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.2% [-5.1%, -2.3%] 4
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 766.925s -> 767.556s (0.08%)
Artifact size: 341.29 MiB -> 341.28 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
6 participants
@matthiaskrgr @bors @rust-timer @rustbot @spastorino @krtab