Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: Accept "improper" ctypes in extern "rust-cold" fn #130667

Merged
merged 1 commit into from
Sep 22, 2024
Merged

compiler: Accept "improper" ctypes in extern "rust-cold" fn #130667

merged 1 commit into from
Sep 22, 2024

Conversation

workingjubilee
Copy link
Member

Closes #125830

@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024
compiler-errors
compiler-errors approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a Rust-* convention we're not promising anything, so can always change the details later.

Yeah, according to the tracking issue this is our ABI to play with so I think it's fine to suppress the ctypes lint here.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 21, 2024

📌 Commit 93993c7 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024
@compiler-errors compiler-errors mentioned this pull request Sep 21, 2024
Open
8 tasks
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#130667 - workingjubilee:she-is-c-c-c-cold, …
0fc976d 
…r=compiler-errors

compiler: Accept "improper" ctypes in extern "rust-cold" fn
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 21, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2024
@bors
Auto merge of rust-lang#130671 - matthiaskrgr:rollup-thahkdd, r=matth…
c64abc3 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` )
 - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses)
 - rust-lang#130246 (rustc_expand: remember module `#[path]`s during expansion)
 - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`)
 - rust-lang#130651 (Add --enable-profiler to armhf dist)
 - rust-lang#130653 (ABI compatibility: mention Result guarantee)
 - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`)
 - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself)
 - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn)

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors compiler-errors mentioned this pull request Sep 21, 2024
Merged
@Noratrieb
Copy link
Member

(and even if this ABI was stable, this is a lint, so the same would apply)

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2024
@bors
Auto merge of rust-lang#130674 - compiler-errors:rollup-yu105fl, r=co…
e2f0c82 
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` )
 - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses)
 - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`)
 - rust-lang#130651 (Add --enable-profiler to armhf dist)
 - rust-lang#130653 (ABI compatibility: mention Result guarantee)
 - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself)
 - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn)
 - rust-lang#130673 (Parser: recover from `:::` to `::`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2024
@bors
Auto merge of rust-lang#130674 - compiler-errors:rollup-yu105fl, r=co…
764e6ae 
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` )
 - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses)
 - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`)
 - rust-lang#130651 (Add --enable-profiler to armhf dist)
 - rust-lang#130653 (ABI compatibility: mention Result guarantee)
 - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself)
 - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn)
 - rust-lang#130673 (Parser: recover from `:::` to `::`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a66563f into rust-lang:master Sep 22, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2024
@rust-timer
Unrolled build for rust-lang#130667
b60c771 
Rollup merge of rust-lang#130667 - workingjubilee:she-is-c-c-c-cold, r=compiler-errors

compiler: Accept "improper" ctypes in extern "rust-cold" fn
@workingjubilee workingjubilee deleted the she-is-c-c-c-cold branch September 22, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.

extern "rust-cold" fns should not trigger improper_ctypes lint
6 participants
@workingjubilee @rustbot @compiler-errors @bors @Noratrieb @michaelwoerister