Register snapshots. Convert most code to new inner attribute syntax. #13068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes issue rust-lang#13067, in which the new inner attribute syntax is incompatible with macro_rules! `attr` matchers. I had to 'ignore' compile-fail/macro-inner-attributes.
|
Do we want to wait for a resolution to #13067? Just in case it impacts this decision. |
|
We got another snapshot over the weekend, so I'm going to close this. |
|
We decided in today's meeting to move forward with the breakage of |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 11, 2024
Rework `init_numbered_fields` Two behaviour changes: * Not linting in macros * Not linting when side effects might be reordered changelog: `init_numbered_fields`: Don't suggest reordering side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes issue #13067, in which the new inner attribute syntax
is incompatible with macro_rules!
attrmatchers. I had to 'ignore'compile-fail/macro-inner-attributes.