Fix target_abi in SOLID targets
#131173
Merged
Fix target_abi in SOLID targets
#131173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `armv7a-kmc-solid_asp3-eabi` and `armv7a-kmc-solid_asp3-eabihf` targets clearly have the ABI in their name, so it should also be exposed in Rust's `target_abi` cfg variable.
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
kawadakk
approved these changes
Oct 3, 2024
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 3, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#130419 (Streamline `HirCollector`) - rust-lang#131163 (Add `get_line` confusable to `Stdin::read_line()`) - rust-lang#131173 (Fix `target_abi` in SOLID targets) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 3, 2024
Rollup merge of rust-lang#131173 - madsmtm:target-info-solid_asp3-abi, r=lcnr Fix `target_abi` in SOLID targets The `armv7a-kmc-solid_asp3-eabi` and `armv7a-kmc-solid_asp3-eabihf` targets clearly have the ABI in their name, so it should also be exposed in Rust's `target_abi` cfg variable. CC target maintainer `@kawadakk.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
armv7a-kmc-solid_asp3-eabiandarmv7a-kmc-solid_asp3-eabihftargets clearly have the ABI in their name, so it should also be exposed in Rust'starget_abicfg variable.CC target maintainer @kawadakk.