-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage: Disable the zombie MC/DC tests until they support LLVM 19 #131388
Conversation
Currently these tests only run against LLVM 18, but the default is now LLVM 19, which makes them very tricky to bless. Since rust-lang#126733 is going to drop support for MC/DC in LLVM 18 anyway, it's easier to just completely disable the tests until that PR fixes them.
Could not assign reviewer from: |
rustbot has assigned @Mark-Simulacrum. Use |
I was originally hoping to avoid this by just approving #126733 myself, but that PR turns out to have bit-rotted slightly and needs a rebase. |
@jieyouxu I believe you were annoyed by these tests recently so you have some context for why they should be disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yeah I ran into this when trying to see if I can bless coverage tests for #130766 locally. The CI llvm got bumped to llvm 19, but these tests require llvm 18, and then becomes a PITA to bless.
@bors r+ rollup |
☔ The latest upstream changes (presumably #126733) made this pull request unmergeable. Please resolve the merge conflicts. |
Obsoleted by #126733. |
Currently these tests only run against LLVM 18, but the default is now LLVM 19, which makes them very tricky to bless. Since #126733 is going to drop support for MC/DC in LLVM 18 anyway, it's easier to just completely disable the tests until that PR fixes them.
(For context, MC/DC is currently unstable anyway, and LLVM's MC/DC APIs have changes between 18 and 19, so supporting both would be an unnecessary headache.)
r? jieyouxu