Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore broken-pipe-no-ice on apple (specifically macOS) for now #131435

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Oct 9, 2024

This test fails for me locally (initially reported by Zalathar) because apparently on macOS it doesn't say "internal compiler error" but it does report the std I/O panic, and it doesn't exit with a code of 101 but instead terminates with a wait signal of SIGPIPE.

Ignore this test on apple for now, until we try to actually address the underlying issue.

See #131155 and #131436 for more context.

@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2024
@jieyouxu jieyouxu added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 9, 2024
@jieyouxu
Copy link
Member Author

jieyouxu commented Oct 9, 2024

r? compiler

@rustbot rustbot assigned TaKO8Ki and unassigned Mark-Simulacrum Oct 9, 2024
@Zalathar

This comment was marked as resolved.

@Zalathar

This comment was marked as duplicate.

@Zalathar
Copy link
Contributor

Zalathar commented Oct 9, 2024

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Oct 9, 2024

📌 Commit fe87487 has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 9, 2024
Ignore broken-pipe-no-ice on apple (specifically macOS) for now

This test fails for me locally (initially reported by Zalathar) because apparently on macOS it doesn't say "internal compiler error" but it does report the std I/O panic, and it doesn't exit with a code of 101 but instead terminates with a wait signal of SIGPIPE.

Ignore this test on apple for now, until we try to actually address the underlying issue.

See rust-lang#131155 and rust-lang#131436 for more context.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 9, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#129424 (Stabilize `Pin::as_deref_mut()`)
 - rust-lang#131417 (Fix methods alignment on mobile)
 - rust-lang#131424 (compiler: Stop reexporting enum-globs from `rustc_target::abi`)
 - rust-lang#131426 (Fix quotation marks around debug line in `src/ci/run.sh`)
 - rust-lang#131429 (Rename directive `needs-profiler-support` to `needs-profiler-runtime`)
 - rust-lang#131435 (Ignore broken-pipe-no-ice on apple (specifically macOS) for now)

r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Oct 9, 2024
Ignore broken-pipe-no-ice on apple (specifically macOS) for now

This test fails for me locally (initially reported by Zalathar) because apparently on macOS it doesn't say "internal compiler error" but it does report the std I/O panic, and it doesn't exit with a code of 101 but instead terminates with a wait signal of SIGPIPE.

Ignore this test on apple for now, until we try to actually address the underlying issue.

See rust-lang#131155 and rust-lang#131436 for more context.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 9, 2024
Rollup of 6 pull requests

Successful merges:

 - rust-lang#131417 (Fix methods alignment on mobile)
 - rust-lang#131420 (Dont ICE when encountering post-mono layout cycle error)
 - rust-lang#131424 (compiler: Stop reexporting enum-globs from `rustc_target::abi`)
 - rust-lang#131426 (Fix quotation marks around debug line in `src/ci/run.sh`)
 - rust-lang#131429 (Rename directive `needs-profiler-support` to `needs-profiler-runtime`)
 - rust-lang#131435 (Ignore broken-pipe-no-ice on apple (specifically macOS) for now)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 9, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#131382 (Add "reference" as a known compiletest header)
 - rust-lang#131420 (Dont ICE when encountering post-mono layout cycle error)
 - rust-lang#131424 (compiler: Stop reexporting enum-globs from `rustc_target::abi`)
 - rust-lang#131426 (Fix quotation marks around debug line in `src/ci/run.sh`)
 - rust-lang#131435 (Ignore broken-pipe-no-ice on apple (specifically macOS) for now)
 - rust-lang#131447 (add more crash tests)
 - rust-lang#131456 (Fix typo in E0793)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 9, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#131382 (Add "reference" as a known compiletest header)
 - rust-lang#131420 (Dont ICE when encountering post-mono layout cycle error)
 - rust-lang#131424 (compiler: Stop reexporting enum-globs from `rustc_target::abi`)
 - rust-lang#131426 (Fix quotation marks around debug line in `src/ci/run.sh`)
 - rust-lang#131435 (Ignore broken-pipe-no-ice on apple (specifically macOS) for now)
 - rust-lang#131447 (add more crash tests)
 - rust-lang#131456 (Fix typo in E0793)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8630de3 into rust-lang:master Oct 10, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
Rollup merge of rust-lang#131435 - jieyouxu:macos-pipe, r=Zalathar

Ignore broken-pipe-no-ice on apple (specifically macOS) for now

This test fails for me locally (initially reported by Zalathar) because apparently on macOS it doesn't say "internal compiler error" but it does report the std I/O panic, and it doesn't exit with a code of 101 but instead terminates with a wait signal of SIGPIPE.

Ignore this test on apple for now, until we try to actually address the underlying issue.

See rust-lang#131155 and rust-lang#131436 for more context.
@jieyouxu jieyouxu deleted the macos-pipe branch October 11, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants