-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stabilize ci_rustc_if_unchanged_logic
test
#131444
Conversation
r? ghost |
Failed to set assignee to
|
ci_rustc_if_unchanged_logic
test if NO_DOWNLOAD_CI_LLVM
is setci_rustc_if_unchanged_logic
test if NO_DOWNLOAD_CI_RUSTC
is set
705c256
to
28620e9
Compare
ci_rustc_if_unchanged_logic
test if NO_DOWNLOAD_CI_RUSTC
is setci_rustc_if_unchanged_logic
test
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot ready |
@@ -3,7 +3,7 @@ | |||
//! we can prove overlap one way or another. Essentially, we treat `Overlap` as | |||
//! a monoid and report a conflict if the product ends up not being `Disjoint`. | |||
//! | |||
//! At each step, if we didn't run out of borrow or place, we know that our elements | |||
//! On each step, if we didn't run out of borrow or place, we know that our elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This made more sense before 😅 But it's a small change anyway.
@bors r+ rollup=never (potentially flaky test) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (249df9e): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 781.006s -> 780.411s (-0.08%) |
Makes
ci_rustc_if_unchanged_logic
test more stable and re-enables it. Previously, it was expecting CI-rustc to be used all the time when there were no changes, which wasn’t always the case. Purpose of this test is making sure we don't use CI-rustc while there are changes in compiler and/or library, but we don't really need to cover cases where CI-rustc is not enabled.Second commit was pushed for making a change in the compiler tree, so
ci_rustc_if_unchanged_logic
can be tested properly in merge CI.