-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support #[repr(simd)] types in input/output of PowerPC inline assembly #131551
Draft
taiki-e
wants to merge
2
commits into
rust-lang:master
Choose a base branch
from
taiki-e:ppc-asm-vreg-inout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+400
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
O-PowerPC
Target: PowerPC processors
labels
Oct 11, 2024
This was referenced Oct 11, 2024
taiki-e
changed the title
Support input/output #[repr(simd)] types in PowerPC inline assembly
Support #[repr(simd)] types in input/output of PowerPC inline assembly
Oct 11, 2024
taiki-e
force-pushed
the
ppc-asm-vreg-inout
branch
2 times, most recently
from
October 11, 2024 15:46
313e9f2
to
ec39701
Compare
This comment has been minimized.
This comment has been minimized.
taiki-e
force-pushed
the
ppc-asm-vreg-inout
branch
from
October 11, 2024 16:34
ec39701
to
f1e798d
Compare
This comment has been minimized.
This comment has been minimized.
taiki-e
force-pushed
the
ppc-asm-vreg-inout
branch
4 times, most recently
from
October 12, 2024 06:49
13b3493
to
97516cb
Compare
taiki-e
commented
Oct 12, 2024
Comment on lines
53
to
57
// FIXME: vsx also supports integers and floats | ||
types! { | ||
altivec: VecI8(16), VecI16(8), VecI32(4), VecF32(4); | ||
vsx: VecI64(2), VecF64(2); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Originally I tried to add I8, I16, I32, I64, F32, F64
to vsx
, but I got "rustc-LLVM ERROR: Unknown mismatch in getCopyFromParts!" in the tests passing integers and floats to vreg.)
taiki-e
force-pushed
the
ppc-asm-vreg-inout
branch
3 times, most recently
from
October 12, 2024 16:17
b2afbe5
to
e9dbcb1
Compare
taiki-e
force-pushed
the
ppc-asm-vreg-inout
branch
from
October 13, 2024 17:12
e9dbcb1
to
bd3190f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-inline-assembly
Area: Inline assembly (`asm!(…)`)
O-PowerPC
Target: PowerPC processors
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #131341. (The first commit is from it.)
Marked as draft until #131341 is merged.
I'm not sticking to whether this should be a separate PR or part of #131341, so I can merge this into #131341 if needed.
r? @Amanieu
@rustbot label +O-PowerPC +A-inline-assembly