Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13140: Early/Late Bound related ICEs. #13157

Merged
merged 3 commits into from
Mar 29, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/librustc/middle/typeck/check/method.rs
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ fn construct_transformed_self_ty_for_object(
let transformed_self_ty = *method_ty.fty.sig.inputs.get(0);
match ty::get(transformed_self_ty).sty {
ty::ty_rptr(r, mt) => { // must be SelfRegion
let r = r.subst(tcx, &substs); // handle Early-Bound lifetime
ty::mk_trait(tcx, trait_def_id, substs,
RegionTraitStore(r), mt.mutbl,
ty::EmptyBuiltinBounds())
Expand Down Expand Up @@ -1435,9 +1436,10 @@ impl<'a> LookupContext<'a> {

impl Repr for Candidate {
fn repr(&self, tcx: &ty::ctxt) -> ~str {
format!("Candidate(rcvr_ty={}, rcvr_substs={}, origin={:?})",
format!("Candidate(rcvr_ty={}, rcvr_substs={}, method_ty={}, origin={:?})",
self.rcvr_match_condition.repr(tcx),
self.rcvr_substs.repr(tcx),
self.method_ty.repr(tcx),
self.origin)
}
}
Expand Down
6 changes: 4 additions & 2 deletions src/librustc/middle/typeck/check/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,10 @@ fn check_bare_fn(ccx: &CrateCtxt,
id: ast::NodeId,
fty: ty::t,
param_env: ty::ParameterEnvironment) {
// Compute the fty from point of view of inside fn
// (replace any type-scheme with a type)
let fty = fty.subst(ccx.tcx, &param_env.free_substs);

match ty::get(fty).sty {
ty::ty_bare_fn(ref fn_ty) => {
let inh = Inherited::new(ccx.tcx, param_env);
Expand Down Expand Up @@ -678,9 +682,7 @@ fn check_method_body(ccx: &CrateCtxt,
method_generics.region_param_defs(),
method.body.id);

// Compute the fty from point of view of inside fn
let fty = ty::node_id_to_type(ccx.tcx, method.id);
let fty = fty.subst(ccx.tcx, &param_env.free_substs);

check_bare_fn(ccx, method.decl, method.body, method.id, fty, param_env);
}
Expand Down
135 changes: 135 additions & 0 deletions src/test/run-pass/regions-early-bound-trait-param.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Tests that you can use an early-bound lifetime parameter as
// on of the generic parameters in a trait.

trait Trait<'a> {
fn long(&'a self) -> int;
fn short<'b>(&'b self) -> int;
}

fn poly_invoke<'c, T: Trait<'c>>(x: &'c T) -> (int, int) {
let l = x.long();
let s = x.short();
(l,s)
}

fn object_invoke1<'d>(x: &'d Trait<'d>) -> (int, int) {
let l = x.long();
let s = x.short();
(l,s)
}

struct Struct1<'e> {
f: &'e Trait<'e>
}

fn field_invoke1<'f, 'g>(x: &'g Struct1<'f>) -> (int,int) {
let l = x.f.long();
let s = x.f.short();
(l,s)
}

struct Struct2<'h, 'i> {
f: &'h Trait<'i>
}

fn object_invoke2<'j, 'k>(x: &'k Trait<'j>) -> int {
x.short()
}

fn field_invoke2<'l, 'm, 'n>(x: &'n Struct2<'l,'m>) -> int {
x.f.short()
}

trait MakerTrait<'o> {
fn mk() -> Self;
}

fn make_val<'p, T:MakerTrait<'p>>() -> T {
MakerTrait::mk()
}

trait RefMakerTrait<'q> {
fn mk(Self) -> &'q Self;
}

fn make_ref<'r, T:RefMakerTrait<'r>>(t:T) -> &'r T {
RefMakerTrait::mk(t)
}

impl<'s> Trait<'s> for (int,int) {
fn long(&'s self) -> int {
let &(x,_) = self;
x
}
fn short<'b>(&'b self) -> int {
let &(_,y) = self;
y
}
}

impl<'t> MakerTrait<'t> for ~Trait<'t> {
fn mk() -> ~Trait<'t> { ~(4,5) as ~Trait }
}

enum List<'l> {
Cons(int, &'l List<'l>),
Null
}

impl<'l> List<'l> {
fn car<'m>(&'m self) -> int {
match self {
&Cons(car, _) => car,
&Null => fail!(),
}
}
fn cdr<'n>(&'n self) -> &'l List<'l> {
match self {
&Cons(_, cdr) => cdr,
&Null => fail!(),
}
}
}

impl<'t> RefMakerTrait<'t> for List<'t> {
fn mk(l:List<'t>) -> &'t List<'t> {
l.cdr()
}
}

pub fn main() {
let t = (2,3);
let o = &t as &Trait;
let s1 = Struct1 { f: o };
let s2 = Struct2 { f: o };
assert_eq!(poly_invoke(&t), (2,3));
assert_eq!(object_invoke1(&t), (2,3));
assert_eq!(field_invoke1(&s1), (2,3));
assert_eq!(object_invoke2(&t), 3);
assert_eq!(field_invoke2(&s2), 3);

let m : ~Trait = make_val();
assert_eq!(object_invoke1(m), (4,5));
assert_eq!(object_invoke2(m), 5);

// The RefMakerTrait above is pretty strange (i.e. it is strange
// to consume a value of type T and return a &T). Easiest thing
// that came to my mind: consume a cell of a linked list and
// return a reference to the list it points to.
let l0 = Null;
let l1 = Cons(1, &l0);
let l2 = Cons(2, &l1);
let rl1 = &l1;
let r = make_ref(l2);
assert_eq!(rl1.car(), r.car());
}