Support lifetime suggestion for method #13164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikomatsakis: r? |
|
@ktt3ja it's generally good practice to have a longer commit message (e.g. describing the change you described in your comment). :) |
|
@huonw: I modified my comment a bit and moved it to the commit and PR messages. |
| //~^ NOTE: consider using an explicit lifetime parameter as shown: fn baz2<'b>(&self, x: &'b int) -> (&'a int, &'b int) | ||
| (self.bar, x) //~ ERROR: cannot infer | ||
| //~^ ERROR: mismatched types | ||
| //~^ ERROR: mismatched types |
There was a problem hiding this comment.
ugh, looks like test failed because I missed a ^. I will put it in there tomorrow...
|
@nikomatsakis: r? |
|
r+ |
This includes a change to the way lifetime names are generated. Say we
figure that `[#0, 'a, 'b]` have to be the same lifetimes, then instead
of just generating a new lifetime `'c` like before to replace them, we
would reuse `'a`. This is done so that when the lifetime name comes
from an impl, we don't give something that's completely off, and we
don't have to do much work to figure out where the name came from. For
example, for the following code snippet:
```rust
struct Baz<'x> {
bar: &'x int
}
impl<'x> Baz<'x> {
fn baz1(&self) -> &int {
self.bar
}
}
```
`[rust-lang#1, 'x]` (where `rust-lang#1` is BrAnon(1) and refers to lifetime of `&int`)
have to be marked the same lifetime. With the old method, we would
generate a new lifetime `'a` and suggest `fn baz1(&self) -> &'a int`
or `fn baz1<'a>(&self) -> &'a int`, both of which are wrong.
|
@nikomatsakis: PR got stale so I just rebased it. |
bors
added a commit
that referenced
this pull request
Apr 15, 2014
…sakis
This includes a change to the way lifetime names are generated. Say we
figure that `[#0, 'a, 'b]` have to be the same lifetimes, then instead
of just generating a new lifetime `'c` like before to replace them, we
would reuse `'a`. This is done so that when the lifetime name comes
from an impl, we don't give something that's completely off, and we
don't have to do much work to figure out where the name came from. For
example, for the following code snippet:
```rust
struct Baz<'x> {
bar: &'x int
}
impl<'x> Baz<'x> {
fn baz1(&self) -> &int {
self.bar
}
}
```
`[#1, 'x]` (where `#1` is BrAnon(1) and refers to lifetime of `&int`)
have to be marked the same lifetime. With the old method, we would
generate a new lifetime `'a` and suggest `fn baz1(&self) -> &'a int`
or `fn baz1<'a>(&self) -> &'a int`, both of which are wrong.
dingxiangfei2009
pushed a commit
to dingxiangfei2009/rust
that referenced
this pull request
Jul 28, 2024
Bump ui_test version -> 0.25 r? `@Alexendoo` cc `@GuillaumeGomez` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a change to the way lifetime names are generated. Say we
figure that
[#0, 'a, 'b]have to be the same lifetimes, then insteadof just generating a new lifetime
'clike before to replace them, wewould reuse
'a. This is done so that when the lifetime name comesfrom an impl, we don't give something that's completely off, and we
don't have to do much work to figure out where the name came from. For
example, for the following code snippet:
[#1, 'x](where#1is BrAnon(1) and refers to lifetime of&int)have to be marked the same lifetime. With the old method, we would
generate a new lifetime
'aand suggestfn baz1(&self) -> &'a intor
fn baz1<'a>(&self) -> &'a int, both of which are wrong.