Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup canonical queries #131748

Merged
merged 6 commits into from
Oct 17, 2024
Merged

cleanup canonical queries #131748

merged 6 commits into from
Oct 17, 2024

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Oct 15, 2024 •
edited
Loading

best reviewed commit by commit. adding CanonicalQueryInput to stop returning defining_opaque_types in query responses is the most involved change here.

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr
Copy link
Contributor Author

lcnr commented Oct 15, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2024
@bors
Auto merge of rust-lang#131748 - lcnr:typing-mode, r=<try>
5e11cca 
cleanup canonical queries

best reviewed commit by commit

r? `@compiler-errors`
@bors
Copy link
Contributor

bors commented Oct 15, 2024

⌛ Trying commit af96e3c with merge 5e11cca...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr
Copy link
Contributor Author

lcnr commented Oct 15, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Oct 15, 2024

⌛ Trying commit 0630c5d with merge 1001cfb...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2024
@bors
Auto merge of rust-lang#131748 - lcnr:typing-mode, r=<try>
1001cfb 
cleanup canonical queries

best reviewed commit by commit. adding `CanonicalQueryInput` to stop returning `defining_opaque_types` in query responses is the most involved change here.

r? `@compiler-errors`
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Oct 15, 2024

☀️ Try build successful - checks-actions
Build commit: 1001cfb (1001cfb26bc1c8fccbc10f02f339e36e16b13ce0)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1001cfb): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.6%, secondary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.6% [1.6%, 1.6%] 1
Regressions ❌
(secondary)		 1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.9% [-1.9%, -1.9%] 2
All ❌✅ (primary) 1.6% [1.6%, 1.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 784.007s -> 781.913s (-0.27%)
Artifact size: 332.69 MiB -> 332.64 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 15, 2024
@compiler-errors
Copy link
Member

r=me after blessing the test suite

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 16, 2024

📌 Commit e744e22 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 16, 2024
@matthiaskrgr
Rollup merge of rust-lang#131748 - lcnr:typing-mode, r=compiler-errors
4b43960 
cleanup canonical queries

best reviewed commit by commit. adding `CanonicalQueryInput` to stop returning `defining_opaque_types` in query responses is the most involved change here.

r? `@compiler-errors`
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 16, 2024
Closed
@bors
Copy link
Contributor

bors commented Oct 16, 2024

☔ The latest upstream changes (presumably #131422) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 16, 2024
@lcnr
Copy link
Contributor Author

lcnr commented Oct 17, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 17, 2024

📌 Commit 6cf4cb8 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2024
@lcnr
Copy link
Contributor Author

lcnr commented Oct 17, 2024

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Oct 17, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Oct 17, 2024

📌 Commit 6cf4cb8 has been approved by compiler-errors

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Oct 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2024
@bors
Auto merge of rust-lang#131827 - matthiaskrgr:rollup-umncb57, r=matth…
03983fb 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#128391 (Change orphan hint from "only" to "any uncovered type inside...")
 - rust-lang#131583 (Setting up indirect access to external data for loongarch64-linux-{musl,ohos})
 - rust-lang#131595 (rustdoc-JSON: Rename "object safe" to "dyn compatible")
 - rust-lang#131748 (cleanup canonical queries)
 - rust-lang#131798 (llvm: Tolerate propagated range metadata)
 - rust-lang#131815 (compiler: use `is_none_or` where it is clearly better)
 - rust-lang#131822 (extract `expr_assign_expected_bool_error`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c1f3702 into rust-lang:master Oct 17, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2024
@rust-timer
Unrolled build for rust-lang#131748
07e00c4 
Rollup merge of rust-lang#131748 - lcnr:typing-mode, r=compiler-errors

cleanup canonical queries

best reviewed commit by commit. adding `CanonicalQueryInput` to stop returning `defining_opaque_types` in query responses is the most involved change here.

r? ``@compiler-errors``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @rustbot @rust-timer @bors @rust-log-analyzer @compiler-errors