Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump backtrace to rust-lang/backtrace@df56954 #131752

Closed
wants to merge 1 commit into from

Conversation

thesummer
Copy link
Contributor

I would like to bump the backtrace submodule a few commits as a follow-up of #127021

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2024
@thesummer
Copy link
Contributor Author

r? @workingjubilee would you be able to check if that is a safe/sane thing to do? You seem to be quite active in the backtrace repo and have also seen the previous PR.

@workingjubilee
Copy link
Member

@thesummer This can/should go up to the APK symbolication change.

The current thing holding back backtrace-rs being at its HEAD is figuring out how much we want to mitigate the size costs of zstd support, as seen in #130417

@thesummer
Copy link
Contributor Author

@workingjubilee Thanks. Then I will close this MR and just wait for the other one to pass through. Thanks for the hint.

@thesummer thesummer closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants