Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable XRay instrumentation for LoongArch Linux targets #131818

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Enable XRay instrumentation for LoongArch Linux targets #131818

merged 1 commit into from
Oct 17, 2024
+3 −0

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Oct 17, 2024

Enable XRay instrumentation for loongarch64-unknown-linux-{gnu, musl, ohos} targets.

@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

jieyouxu
jieyouxu approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can r=me after PR CI is green.

@jieyouxu jieyouxu assigned jieyouxu and unassigned petrochenkov Oct 17, 2024
@jieyouxu
Copy link
Member

@bors delegate+ rollup

@bors
Copy link
Contributor

bors commented Oct 17, 2024

✌️ @heiher, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 17, 2024

📌 Commit dd66134 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2024
@heiher heiher force-pushed the loong-instrument-xray branch from dd66134 to 67ed9fa Compare October 17, 2024 14:35
@jieyouxu
Copy link
Member

jieyouxu commented Oct 17, 2024 •
edited
Loading

@bors r- (wrong branch / incorrect rebase?) i looked at the wrong diff

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 17, 2024
@jieyouxu
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2024

📌 Commit 67ed9fa has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2024
@heiher
Copy link
Contributor Author

heiher commented Oct 17, 2024

@bors r- (wrong branch / incorrect rebase?)

The previous commit conflicts with the just-merged pr #131583

@jieyouxu
Copy link
Member

jieyouxu commented Oct 17, 2024 •
edited
Loading

Yeah, I clicked the wrong button which took me to a different diff 😆

@matthiaskrgr matthiaskrgr mentioned this pull request Oct 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2024
@bors
Auto merge of rust-lang#131848 - matthiaskrgr:rollup-l29a75j, r=matth…
3ed6e3c 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129620 (Provide a more convinient way of developing rustc on NixOS)
 - rust-lang#131805 (rustc_llvm: Fix flattened CLI args)
 - rust-lang#131818 (Enable XRay instrumentation for LoongArch Linux targets)
 - rust-lang#131825 (SolverDelegate add assoc type for Infcx)
 - rust-lang#131833 (Add `must_use` to `CommandExt::exec`)
 - rust-lang#131835 (Do not run test where it cannot run)
 - rust-lang#131844 (Add mailmap entry for kobzol)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7dbd92f into rust-lang:master Oct 17, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2024
@rust-timer
Unrolled build for rust-lang#131818
c174125 
Rollup merge of rust-lang#131818 - heiher:loong-instrument-xray, r=jieyouxu

Enable XRay instrumentation for LoongArch Linux targets

Enable XRay instrumentation for `loongarch64-unknown-linux-{gnu, musl, ohos}` targets.
@heiher heiher deleted the loong-instrument-xray branch October 18, 2024 01:10
@jieyouxu
Copy link
Member

Actually going to add relnotes for this just as a FYI.
@rustbot label +relnotes

@rustbot rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 26, 2024
@rustbot rustbot mentioned this pull request Oct 26, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
5 participants
@heiher @rustbot @jieyouxu @bors @petrochenkov