Allow dropping dyn principal #131857
Merged
Allow dropping dyn principal #131857
+167
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 The Miri subtree was changed cc @rust-lang/miri |
compiler-errors
approved these changes
Oct 17, 2024
|
|
||
| impl<T: Send + Sync> Bar for T {} | ||
|
|
||
| const fn yeet_principal_2(x: Box<dyn Bar>) -> Box<dyn Send> { |
There was a problem hiding this comment.
yay thanks for testing this one specifically :3
There was a problem hiding this comment.
This was actually @Jules-Bertholet :D
I only added a dyn* test as asked by lcnr.
|
r=me after ci passes, unless you want a review from lcnr specifically |
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#131654 (Various fixes for Xous) - rust-lang#131743 (rustc_metadata: minor tidying) - rust-lang#131823 (Bump libc to 0.2.161) - rust-lang#131850 (Missing parenthesis) - rust-lang#131857 (Allow dropping dyn principal) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2024
Rollup merge of rust-lang#131857 - WaffleLapkin:dyn-drop-principal-3, r=compiler-errors Allow dropping dyn principal Revival of rust-lang#126660, which was a revival of rust-lang#114679. Fixes rust-lang#126313. Allows dropping principal when coercing trait objects, e.g. `dyn Debug + Send` -> `dyn Send`. cc `@compiler-errors` `@Jules-Bertholet` r? `@lcnr`
lcnr
added
the
relnotes
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of #126660, which was a revival of #114679. Fixes #126313.
Allows dropping principal when coercing trait objects, e.g.
dyn Debug + Send->dyn Send.cc @compiler-errors @Jules-Bertholet
r? @lcnr