-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rustc-hash to version 2 but again #131949
Conversation
Some changes occurred in exhaustiveness checking cc @Nadrieril rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi Changes to the size of AST and/or HIR nodes. cc @nnethercote These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
@bors try |
…try> Update rustc-hash to version 2 but again it's like rust-lang#129533 but not closed by bors and rebased r? WaffleLapkin meow
@bors rollup=never |
☀️ Try build successful - checks-actions |
@bors r=WaffleLapkin |
☔ The latest upstream changes (presumably #131948) made this pull request unmergeable. Please resolve the merge conflicts. |
This brings in the new algorithm.
Just because the code says it's OK does not mean that it actually is OK. Nodes with the same total size were not sorted, their order relied on hashmap iteration.
Bors thinks this is queued? |
rebasededed |
8208f88
to
0c8d81b
Compare
@bors r=WaffleLapkin |
…affleLapkin Update rustc-hash to version 2 but again it's like rust-lang#129533 but not closed by bors and rebased r? WaffleLapkin meow
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
don't terminate my batch job D: |
as this PR has encountered many curses and has already had to be reopened: @bors p=1 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (662180b): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.1%, secondary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (secondary 0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 782.102s -> 781.679s (-0.05%) |
@rustbot label: +perf-regression-triaged |
it's like #129533 but not closed by bors and rebased
r? WaffleLapkin meow