Hack out effects support for old solver #132119

compiler-errors · 2024-10-24T20:43:36Z

Opening this for vibes ✨

Turns out that a basic, somewhat incomplete implementation of host effects is achievable in the old trait solver pretty easily. This should be sufficient for us to use in the standard library itself.

Regarding incompleteness, maybe we should always treat host predicates as ambiguous in intercrate mode (at least in the old solver) to avoid any worries about accidental impl overlap or something.

r? @lcnr cc @fee1-dead

lcnr · 2024-10-24T22:19:50Z

compiler/rustc_trait_selection/src/traits/effects.rs

+                if candidate.is_some() {
+                } else {


nyaaa?

either add a comment or modify the impl

yeah this impl is scuffed lol

This should've been a return Err(EvaluationFailure::Ambiguous), so we bail on ambiguity if there are 2 applicable w.c.

lcnr · 2024-10-24T22:24:49Z

compiler/rustc_trait_selection/src/traits/select/mod.rs

-                    todo!()
+                ty::PredicateKind::Clause(ty::ClauseKind::HostEffect(data)) => {
+                    self.infcx.enter_forall(bound_predicate.rebind(data), |data| {
+                        match effects::evaluate_host_effect_obligation(


pretty sure that can cause undetected overflow 🤔 too tired to explain my thoughts here via comment for today, can do so in sync or maybe you're able to come up with a test yourself

Yeah, though it's the same way that we can encounter overflow in projection afaict.

This is just a consequence of not tracking effect goals (or projections) on the trait stack.

fee1-dead

The test changes appear correct to me. For the solver parts I did not see anything else than what lcnr commented on (in my limited understanding of the trait solver infra)

bors · 2024-10-26T16:36:55Z

☔ The latest upstream changes (presumably #132184) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_trait_selection/src/traits/fulfill.rs

compiler-errors · 2024-10-28T19:28:57Z

compiler/rustc_trait_selection/src/traits/effects.rs

+                            .instantiate(tcx, impl_.args)
+                            .into_iter()
+                            .map(|(trait_ref, _)| {
+                                obligation.with(


Increment the depth correctly

Did this more manually. It's kinda ugly but 🤷

lcnr

pls do:

incr obligation depth when recursing in evaluate host effect
ICE when used with intercrate mode

r=me after

compiler-errors · 2024-10-29T00:25:11Z

@bors r=lcnr

bors · 2024-10-29T00:25:14Z

📌 Commit 8b7b8e5 has been approved by lcnr

It is now in the queue for this repository.

…, r=lcnr Hack out effects support for old solver Opening this for vibes ✨ Turns out that a basic, somewhat incomplete implementation of host effects is achievable in the old trait solver pretty easily. This should be sufficient for us to use in the standard library itself. Regarding incompleteness, maybe we should always treat host predicates as ambiguous in intercrate mode (at least in the old solver) to avoid any worries about accidental impl overlap or something. r? `@lcnr` cc `@fee1-dead`

…, r=lcnr Hack out effects support for old solver Opening this for vibes ✨ Turns out that a basic, somewhat incomplete implementation of host effects is achievable in the old trait solver pretty easily. This should be sufficient for us to use in the standard library itself. Regarding incompleteness, maybe we should always treat host predicates as ambiguous in intercrate mode (at least in the old solver) to avoid any worries about accidental impl overlap or something. r? ``@lcnr`` cc ``@fee1-dead``

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#131375 (compiler: apply clippy::clone_on_ref_ptr for CI) - rust-lang#132119 (Hack out effects support for old solver) - rust-lang#132151 (Ensure that resume arg outlives region bound for coroutines) - rust-lang#132216 (correct LLVMRustCreateThinLTOData arg types) - rust-lang#132233 (Split `boxed.rs` into a few modules) - rust-lang#132266 (riscv-soft-abi-with-float-features.rs: adapt for LLVM 20) - rust-lang#132270 (clarified doc for `std::fs::OpenOptions.truncate()`) - rust-lang#132274 (Cleanup op lookup in HIR typeck) - rust-lang#132284 (Remove my ping for rustdoc/clean/types.rs) - rust-lang#132293 (Remove myself from mentions inside `tests/ui/check-cfg` directory) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 12 pull requests Successful merges: - rust-lang#131375 (compiler: apply clippy::clone_on_ref_ptr for CI) - rust-lang#131520 (Mark `str::is_char_boundary` and `str::split_at*` unstably `const`.) - rust-lang#132119 (Hack out effects support for old solver) - rust-lang#132194 (Collect item bounds for RPITITs from trait where clauses just like associated types) - rust-lang#132216 (correct LLVMRustCreateThinLTOData arg types) - rust-lang#132233 (Split `boxed.rs` into a few modules) - rust-lang#132266 (riscv-soft-abi-with-float-features.rs: adapt for LLVM 20) - rust-lang#132270 (clarified doc for `std::fs::OpenOptions.truncate()`) - rust-lang#132284 (Remove my ping for rustdoc/clean/types.rs) - rust-lang#132293 (Remove myself from mentions inside `tests/ui/check-cfg` directory) - rust-lang#132312 (Delete `tests/crashes/23707.rs` because it's flaky) - rust-lang#132313 (compiletest: Rename `command-list.rs` to `directive-list.rs`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132119 - compiler-errors:effects-old-solver, r=lcnr Hack out effects support for old solver Opening this for vibes ✨ Turns out that a basic, somewhat incomplete implementation of host effects is achievable in the old trait solver pretty easily. This should be sufficient for us to use in the standard library itself. Regarding incompleteness, maybe we should always treat host predicates as ambiguous in intercrate mode (at least in the old solver) to avoid any worries about accidental impl overlap or something. r? ```@lcnr``` cc ```@fee1-dead```

…kingjubilee Rollup of 12 pull requests Successful merges: - rust-lang#131375 (compiler: apply clippy::clone_on_ref_ptr for CI) - rust-lang#131520 (Mark `str::is_char_boundary` and `str::split_at*` unstably `const`.) - rust-lang#132119 (Hack out effects support for old solver) - rust-lang#132194 (Collect item bounds for RPITITs from trait where clauses just like associated types) - rust-lang#132216 (correct LLVMRustCreateThinLTOData arg types) - rust-lang#132233 (Split `boxed.rs` into a few modules) - rust-lang#132266 (riscv-soft-abi-with-float-features.rs: adapt for LLVM 20) - rust-lang#132270 (clarified doc for `std::fs::OpenOptions.truncate()`) - rust-lang#132284 (Remove my ping for rustdoc/clean/types.rs) - rust-lang#132293 (Remove myself from mentions inside `tests/ui/check-cfg` directory) - rust-lang#132312 (Delete `tests/crashes/23707.rs` because it's flaky) - rust-lang#132313 (compiletest: Rename `command-list.rs` to `directive-list.rs`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned lcnr Oct 24, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2024

lcnr reviewed Oct 24, 2024

View reviewed changes

compiler-errors mentioned this pull request Oct 25, 2024

Making impls const across bootstrap versions rust-lang/project-const-traits#7

Open

fee1-dead reviewed Oct 26, 2024

View reviewed changes

compiler-errors force-pushed the effects-old-solver branch from b4e9eeb to 758d2d5 Compare October 26, 2024 16:58

compiler-errors commented Oct 28, 2024

View reviewed changes

compiler/rustc_trait_selection/src/traits/fulfill.rs Outdated Show resolved Hide resolved

compiler-errors commented Oct 28, 2024

View reviewed changes

lcnr reviewed Oct 28, 2024

View reviewed changes

compiler-errors force-pushed the effects-old-solver branch from 758d2d5 to 824b932 Compare October 28, 2024 21:39

Hack out effects support for old solver

8b7b8e5

compiler-errors force-pushed the effects-old-solver branch from 824b932 to 8b7b8e5 Compare October 28, 2024 21:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2024

workingjubilee mentioned this pull request Oct 29, 2024

Rollup of 13 pull requests #132299

Closed

workingjubilee mentioned this pull request Oct 29, 2024

Rollup of 10 pull requests #132300

Closed

workingjubilee mentioned this pull request Oct 29, 2024

Rollup of 12 pull requests #132317

Merged

bors merged commit e97286e into rust-lang:master Oct 29, 2024
6 checks passed

rustbot added this to the 1.84.0 milestone Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hack out effects support for old solver #132119

Hack out effects support for old solver #132119

compiler-errors commented Oct 24, 2024

lcnr Oct 24, 2024

compiler-errors Oct 24, 2024

compiler-errors Oct 24, 2024

lcnr Oct 24, 2024

compiler-errors Oct 24, 2024

compiler-errors Oct 24, 2024

fee1-dead left a comment

bors commented Oct 26, 2024

compiler-errors Oct 28, 2024

compiler-errors Oct 28, 2024

lcnr left a comment •

edited

Loading

compiler-errors commented Oct 29, 2024

bors commented Oct 29, 2024

Hack out effects support for old solver #132119

Hack out effects support for old solver #132119

Conversation

compiler-errors commented Oct 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fee1-dead left a comment

Choose a reason for hiding this comment

bors commented Oct 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lcnr left a comment • edited Loading

Choose a reason for hiding this comment

compiler-errors commented Oct 29, 2024

bors commented Oct 29, 2024

lcnr left a comment •

edited

Loading