Stabilise `const_char_encode_utf16`. #132153

bjoernager · 2024-10-25T20:58:31Z

This PR stabilises the const_char_encode_utf16 feature gate (i.e. support for char::encode_utf16 in constant expressions).

~~Note that the linked tracking issue is as of this writing currently awaiting FCP until 2024-11-02.~~

rustbot · 2024-10-25T20:58:39Z

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bjoernager · 2024-10-25T20:59:35Z

@rustbot label +T-libs-api -T-libs

r? libs-api

bjoernager · 2024-11-02T16:46:25Z

@rustbot label -S-waiting-on-fcp

bjoernager · 2024-11-02T16:47:05Z

FCP has completed now.

dtolnay

Thanks!

dtolnay · 2024-11-02T16:47:41Z

@bors r+

bors · 2024-11-02T16:47:43Z

📌 Commit 764349f has been approved by dtolnay

It is now in the queue for this repository.

…, r=dtolnay Stabilise `const_char_encode_utf16`. Closes: rust-lang#130660 This PR stabilises the `const_char_encode_utf16` feature gate (i.e. support for `char::encode_utf16` in constant expressions). ~~Note that the linked tracking issue is as of this writing currently awaiting FCP until 2024-11-02.~~

…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132419 (PassWrapper: adapt for llvm/llvm-project@b01e2a8b5620466c3b) - rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate) - rust-lang#132458 (get rid of a whole bunch of unnecessary rustc_const_unstable attributes) - rust-lang#132520 (NFC add known bug nr to test) - rust-lang#132522 (make codegen help output more consistent) - rust-lang#132523 (Added regression test for generics index out of bounds) - rust-lang#132528 (Use `*_opt` typeck results fns to not ICE in fallback suggestion) Failed merges: - rust-lang#132511 (stabilize const_arguments_as_str) r? `@ghost` `@rustbot` modify labels: rollup

GuillaumeGomez · 2024-11-02T20:21:33Z

Failed in #132538.

@bors r-

tgross35 · 2024-11-02T20:59:25Z

library/core/src/char/methods.rs

 #[unstable(feature = "char_internals", reason = "exposed only for libstd", issue = "none")]
-#[rustc_const_unstable(feature = "const_char_encode_utf16", issue = "130660")]
+#[rustc_const_stable(feature = "const_char_encode_utf16", since = "CURRENT_RUSTC_VERSION")]
 #[doc(hidden)]
 #[inline]
+#[rustc_allow_const_fn_unstable(const_eval_select)]
 pub const fn encode_utf16_raw(mut code: u32, dst: &mut [u16]) -> &mut [u16] {


The way this works changed in #131349. I believe encode_utf16_raw needs to lose the rustc_const_{un}stable and rustc_allow_const_fn_unstable gates and instead get #[cfg_attr(not(bootstrap), rustc_const_stable_indirect)].

You might also need to change the rustc_const_stable on encode_utf16 to #[cfg_attr(not(bootstrap), rustc_const_stable)] so it only becomes const stable when the new stability checking is available.

Cc @rust-lang/wg-const-eval, I'm not positive about the right thing to do while the new checks aren't in bootstrap.

I hope the docs at https://rustc-dev-guide.rust-lang.org/stability.html#rustc_const_unstable are helpful :)

But yes, an unstable function cannot be rustc_const_stable in the new regime. But the trouble is this code needs to build both with the bootstrap compiler and the latest nightly compiler, so the result should be something like

#[cfg_attr(bootstrap, rustc_const_stable(feature = "const_char_encode_utf16", since = "CURRENT_RUSTC_VERSION"))] #[rustc_allow_const_fn_unstable(const_eval_select)]

Also please add a comment explaining why allowing const_eval_select is okay.

You might also need to change the rustc_const_stable on encode_utf16 to #[cfg_attr(not(bootstrap), rustc_const_stable)] so it only becomes const stable when the new stability checking is available.

That should not be needed.

dtolnay · 2024-11-04T13:20:00Z

@bors r+

bors · 2024-11-04T13:20:03Z

📌 Commit 7faa84e has been approved by dtolnay

It is now in the queue for this repository.

…, r=dtolnay Stabilise `const_char_encode_utf16`. Closes: rust-lang#130660 This PR stabilises the `const_char_encode_utf16` feature gate (i.e. support for `char::encode_utf16` in constant expressions). ~~Note that the linked tracking issue is as of this writing currently awaiting FCP until 2024-11-02.~~

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132355 (Fix compiler panic with a large number of threads) - rust-lang#132486 (No need to instantiate binder in `confirm_async_closure_candidate`) - rust-lang#132594 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup

…, r=dtolnay Stabilise `const_char_encode_utf16`. Closes: rust-lang#130660 This PR stabilises the `const_char_encode_utf16` feature gate (i.e. support for `char::encode_utf16` in constant expressions). ~~Note that the linked tracking issue is as of this writing currently awaiting FCP until 2024-11-02.~~

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#129884 (mark some target features as 'forbidden' so they cannot be (un)set with -Ctarget-feature) - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132473 ([core/fmt] Replace checked slice indexing by unchecked to support panic-free code) - rust-lang#132571 (add const_eval_select macro to reduce redundancy) - rust-lang#132587 (Revert "Avoid nested replacement ranges" from rust-lang#129346.) - rust-lang#132596 ([rustdoc] Fix `--show-coverage` when JSON output format is used) - rust-lang#132598 (Clippy: Move some attribute lints to be early pass (post expansion)) - rust-lang#132601 (Update books) - rust-lang#132606 (Improve example of `impl Pattern for &[char]`) - rust-lang#132609 (docs: fix grammar in doc comment at unix/process.rs) r? `@ghost` `@rustbot` modify labels: rollup

…, r=dtolnay Stabilise `const_char_encode_utf16`. Closes: rust-lang#130660 This PR stabilises the `const_char_encode_utf16` feature gate (i.e. support for `char::encode_utf16` in constant expressions). ~~Note that the linked tracking issue is as of this writing currently awaiting FCP until 2024-11-02.~~

Rollup of 9 pull requests Successful merges: - rust-lang#131153 (Improve duplicate derive Copy/Clone diagnostics) - rust-lang#131341 (Support clobber_abi and vector registers (clobber-only) in PowerPC inline assembly) - rust-lang#132025 (fix suggestion for diagnostic error E0027) - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132303 (More tests for non-exhaustive C-like enums in FFI) - rust-lang#132473 ([core/fmt] Replace checked slice indexing by unchecked to support panic-free code) - rust-lang#132598 (Clippy: Move some attribute lints to be early pass (post expansion)) - rust-lang#132606 (Improve example of `impl Pattern for &[char]`) - rust-lang#132609 (docs: fix grammar in doc comment at unix/process.rs) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132473 ([core/fmt] Replace checked slice indexing by unchecked to support panic-free code) - rust-lang#132600 (PassWrapper: adapt for new parameter in LLVM) - rust-lang#132630 (triagebot: ping wg-const-eval when relevant files change) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2024-11-05T18:36:49Z

Bizarrely high rate of merge conflicts.

@bors p=1

…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132473 ([core/fmt] Replace checked slice indexing by unchecked to support panic-free code) - rust-lang#132600 (PassWrapper: adapt for new parameter in LLVM) - rust-lang#132630 (triagebot: ping wg-const-eval when relevant files change) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132153 - bjoernager:const-char-encode-utf16, r=dtolnay Stabilise `const_char_encode_utf16`. Closes: rust-lang#130660 This PR stabilises the `const_char_encode_utf16` feature gate (i.e. support for `char::encode_utf16` in constant expressions). ~~Note that the linked tracking issue is as of this writing currently awaiting FCP until 2024-11-02.~~

rustbot assigned cuviper Oct 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 25, 2024

bjoernager mentioned this pull request Oct 25, 2024

Tracking Issue for const_char_encode_utf16 #130660

Closed

3 tasks

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 25, 2024

rustbot assigned Amanieu and unassigned cuviper Oct 25, 2024

tgross35 added the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Oct 26, 2024

rustbot removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Nov 2, 2024

dtolnay approved these changes Nov 2, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2024

dtolnay assigned dtolnay and unassigned Amanieu Nov 2, 2024

GuillaumeGomez mentioned this pull request Nov 2, 2024

Rollup of 8 pull requests #132538

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 2, 2024

tgross35 reviewed Nov 2, 2024

View reviewed changes

workingjubilee closed this Nov 2, 2024

workingjubilee reopened this Nov 2, 2024

rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Nov 4, 2024

This comment was marked as outdated.

Sign in to view

bjoernager reopened this Nov 4, 2024

This comment has been minimized.

Sign in to view

bjoernager force-pushed the const-char-encode-utf16 branch from 7561445 to 98ad987 Compare November 4, 2024 11:43

This comment has been minimized.

Sign in to view

Stabilise 'const_char_encode_utf16';

7faa84e

bjoernager force-pushed the const-char-encode-utf16 branch from 98ad987 to 7faa84e Compare November 4, 2024 12:09

dtolnay approved these changes Nov 4, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 4, 2024

matthiaskrgr mentioned this pull request Nov 4, 2024

Rollup of 4 pull requests #132595

Closed

workingjubilee mentioned this pull request Nov 4, 2024

Rollup of 10 pull requests #132616

Closed

tgross35 mentioned this pull request Nov 5, 2024

Rollup of 9 pull requests #132621

Closed

workingjubilee mentioned this pull request Nov 5, 2024

Rollup of 4 pull requests #132631

Merged

matthiaskrgr mentioned this pull request Nov 5, 2024

Rollup of 6 pull requests #132652

Closed

bors merged commit 1ee6617 into rust-lang:master Nov 5, 2024
6 checks passed

rustbot added this to the 1.84.0 milestone Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilise `const_char_encode_utf16`. #132153

Stabilise `const_char_encode_utf16`. #132153

bjoernager commented Oct 25, 2024 •

edited

Loading

rustbot commented Oct 25, 2024

bjoernager commented Oct 25, 2024

bjoernager commented Nov 2, 2024

bjoernager commented Nov 2, 2024

dtolnay left a comment

dtolnay commented Nov 2, 2024

bors commented Nov 2, 2024

GuillaumeGomez commented Nov 2, 2024

tgross35 Nov 2, 2024

RalfJung Nov 2, 2024

RalfJung Nov 2, 2024

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

dtolnay commented Nov 4, 2024

bors commented Nov 4, 2024

workingjubilee commented Nov 5, 2024 •

edited

Loading

Stabilise const_char_encode_utf16. #132153

Stabilise const_char_encode_utf16. #132153

Conversation

bjoernager commented Oct 25, 2024 • edited Loading

rustbot commented Oct 25, 2024

bjoernager commented Oct 25, 2024

bjoernager commented Nov 2, 2024

bjoernager commented Nov 2, 2024

dtolnay left a comment

Choose a reason for hiding this comment

dtolnay commented Nov 2, 2024

bors commented Nov 2, 2024

GuillaumeGomez commented Nov 2, 2024

tgross35 Nov 2, 2024

Choose a reason for hiding this comment

RalfJung Nov 2, 2024

Choose a reason for hiding this comment

RalfJung Nov 2, 2024

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

dtolnay commented Nov 4, 2024

bors commented Nov 4, 2024

workingjubilee commented Nov 5, 2024 • edited Loading

Stabilise `const_char_encode_utf16`. #132153

Stabilise `const_char_encode_utf16`. #132153

bjoernager commented Oct 25, 2024 •

edited

Loading

workingjubilee commented Nov 5, 2024 •

edited

Loading