vec: convert append and append_one to methods
#13221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were only free functions on `~[T]` because taking self by-value used to be broken.
bors
added a commit
that referenced
this pull request
Mar 31, 2014
These were only free functions on `~[T]` because taking self by-value used to be broken.
notriddle
pushed a commit
to notriddle/rust
that referenced
this pull request
Sep 20, 2022
…tem, r=Veykril Allow configuration of annotation location. I've added the ability to configure where lens annotations render relevant to the item they describe. Previously, these would render directly above the line the item is declared on. Now, there is the ability to render these annotations above the entire item (including doc comments, and attributes). The names of the config options are up for debate, I did what seemed best to me but if anyone has better ideas let me know. This is my first contribution so if I've missed anything please let me know. Here's a preview of what the new option looks like: <img width="577" alt="Screen Shot 2022-09-11 at 10 39 51 PM" src="https://user-images.githubusercontent.com/33100798/189570298-b4fcbf9c-ee49-4b79-aae6-1037ae4f26af.png"> closes rust-lang/rust-analyzer#13218
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 24, 2024
…, r=xFrednet Replace the metadata collector with tests The metadata collector handles 3 files: [`CHANGELOG.md`](https://github.com/rust-lang/rust-clippy/blob/c082bc2cb85313901ed3565fcd285592ed93df0f/CHANGELOG.md#L6050), [`lint_configuration.md`](https://github.com/rust-lang/rust-clippy/blob/c082bc2cb85313901ed3565fcd285592ed93df0f/book/src/lint_configuration.md) and `util/gh-pages/lints.json` - `CHANGELOG.md` and `lint_configuration.md` are now checked by `tests/config-metadata.rs`, when they are outdated `cargo test` will fail with a message to run `cargo bless --test config-metadata` in order to update them A plain `cargo bless` will run all the tests, blessing both this and the UI tests - `util/gh-pages/lints.json` is now generated when running `cargo uitest` with `COLLECT_METADATA=1` (still aliased to `cargo collect-metadata`) It uses a `ui_test` [post test action](https://docs.rs/ui_test/latest/ui_test/custom_flags/trait.Flag.html#method.post_test_action) to retrieve the applicability from the actual diagnostics emitted during UI tests Example change from the current to new JSON: ```diff { "id": "chars_next_cmp", - "id_span": { - "path": "src/methods/mod.rs", - "line": 891 - }, + "id_location": "clippy_lints/src/methods/mod.rs#891", "group": "style", "level": "warn", - "docs": "\n### What it does ... ```", + "docs": "### What it does ... ```\n", "version": "pre 1.29.0", - "applicability": { - "is_multi_part_suggestion": false, - "applicability": "Unresolved" - } + "applicability": "MachineApplicable" }, ``` `Hide whitespace` makes the `compile-test.rs` changes much easier to see r? `@flip1995` changelog: none
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
…, r=llogiq Remove unused `collect_metadata` function Leftover from rust-lang#13221 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were only free functions on
~[T]because taking self by-valueused to be broken.