Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #132308

Closed
wants to merge 29 commits into from

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    6d569f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Configuration menu
    Copy the full SHA
    6ab87f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. Configuration menu
    Copy the full SHA
    42fbaf1 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. compiler: Add rustc_abi dependence to the compiler

    Depend on rustc_abi in compiler crates that use it indirectly but have
    not yet taken on that dependency, and are not entangled in my other PRs.
    This leaves an "excise rustc_target" step after the dust settles.
    workingjubilee committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    4839d6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb08e08 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1a39247 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e3bf50e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3f73fe7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7cfbe23 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    26b6ccd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4bd84b2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    82bfe05 View commit details
    Browse the repository at this point in the history
  10. Updating Fuchsia platform-support documentation

    Updated for changes in the package server workflow.
    claywilkinson committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2cc9d58 View commit details
    Browse the repository at this point in the history
  11. compiler: Add is_uninhabited and use LayoutS accessors

    This reduces the need of the compiler to peek on the fields of LayoutS.
    workingjubilee committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    88a9edc View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    641ce06 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    5f91811 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    673867e View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Rollup merge of rust-lang#130259 - adwinwhite:lower-node-id-once, r=c…

    …jgillot
    
    Lower AST node id only once
    
    Fixes rust-lang#96346.
    
    I basically followed the given instructions except the inline part.
    
    `lower_jump_destination` can't reuse local existing `HirId` due to unknown name resolution result so I created an additional mapping for labels.
    
    r? `````@cjgillot`````
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8223991 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#131441 - SpriteOvO:proc-macro-to-tokens-tra…

    …it, r=dtolnay
    
    Add a new trait `proc_macro::ToTokens`
    
    Tracking issue rust-lang#130977
    
    This PR adds a new trait `ToTokens`, implemented for types that can be interpolated inside a `quote!` invocation.
    
    ```rust
    impl ToTokens for TokenTree
    impl ToTokens for TokenStream
    impl ToTokens for Literal
    impl ToTokens for Ident
    impl ToTokens for Punct
    impl ToTokens for Group
    impl<T: ToTokens + ?Sized> ToTokens for &T
    impl<T: ToTokens + ?Sized> ToTokens for &mut T
    impl<T: ToTokens + ?Sized> ToTokens for Box<T>
    impl<T: ToTokens + ?Sized> ToTokens for Rc<T>
    impl<T: ToTokens + ToOwned + ?Sized> ToTokens for Cow<'_, T>
    impl<T: ToTokens> ToTokens for Option<T>
    impl ToTokens for u{8,16,32,64,128}
    impl ToTokens for i{8,16,32,64,128}
    impl ToTokens for f{32,64}
    impl ToTokens for {u,i}size
    impl ToTokens for bool
    impl ToTokens for char
    impl ToTokens for str
    impl ToTokens for String
    impl ToTokens for CStr
    impl ToTokens for CString
    ```
    
    ~This PR also implements the migration mentioned in the tracking issue, replacing `Extend<Token{Tree,Stream}>` with `Extend<T: ToTokens>`, and replacing `FromIterator<Token{Tree,Stream}>` with `FromIterator<T: ToTokens>`.~
    **UPDATE**: Reverted.
    
    ```diff
    -impl FromIterator<TokenTree> for TokenStream
    -impl FromIterator<TokenStream> for TokenStream
    +impl<T: ToTokens> FromIterator<T> for TokenStream
    
    -impl Extend<TokenTree> for TokenStream
    -impl Extend<TokenStream> for TokenStream
    +impl<T: ToTokens> Extend<T> for TokenStream
    ```
    
    I'm going to leave some comments in the review where I'm unsure and concerned.
    
    r? ````@dtolnay````
    CC ````@tgross35````
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    90e57a2 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#131984 - dingxiangfei2009:stabilize-if-let-…

    …rescope, r=traviscross,lcnr
    
    Stabilize if_let_rescope
    
    Close rust-lang#131154
    Tracked by rust-lang#124085
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3b55ce9 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#132194 - compiler-errors:rpitit-super-wc, r…

    …=spastorino
    
    Collect item bounds for RPITITs from trait where clauses just like associated types
    
    We collect item bounds from trait where clauses for *associated types*, i.e. this:
    
    ```rust
    trait Foo
    where
        Self::Assoc: Send
    {
        type Assoc;
    }
    ```
    
    Becomes this:
    
    ```rust
    trait Foo {
        type Assoc: Send;
    }
    ```
    
    Today, with RPITITs/AFIT and return-type notation, we don't do that, i.e.:
    
    ```rust
    trait Foo where Self::method(..): Send {
        fn method() -> impl Sized;
    }
    
    fn is_send(_: impl Send) {}
    fn test<T: Foo>() {
        is_send(T::method());
    }
    ```
    
    ...which fails on nightly today.
    
     Turns out it's super easy to fix this, and we just need to use the `associated_type_bounds` lowering function in `explicit_item_bounds_with_filter`, which has that logic baked in.
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    de44536 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#132247 - workingjubilee:add-rustc-abi-to-sm…

    …ir, r=celinval
    
    stable_mir: Directly use types from rustc_abi
    
    In most cases, rustc_target is not necessary, so use rustc_abi instead of its reexports.
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3b17361 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#132249 - workingjubilee:add-rustc-abi, r=co…

    …mpiler-errors
    
    compiler: Add rustc_abi dependence to the compiler
    
    Depend on rustc_abi in compiler crates that use it indirectly but have not yet taken on that dependency, and are not *significantly* entangled in my other PRs. This leaves an "excise rustc_target" step after the dust settles.
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    37aa14b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#132255 - workingjubilee:layout-is-🏚️, r=com…

    …piler-errors
    
    Add `LayoutData::is_uninhabited` and use it
    
    Use accessors for the things that accessors are good at: reducing everyone's need to be nosy and peek at the internals of every data structure.
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f60f9dd View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#132258 - GuillaumeGomez:variant-structfield…

    …s-margins, r=notriddle
    
    [rustdoc] Unify variant struct fields margins with struct fields
    
    As discussed in rust-lang#132220.
    
    | before | after |
    |-|-|
    | ![image](https://github.com/user-attachments/assets/d8d8336d-7fe4-45fb-a5a5-36a4023223f5) | ![Screenshot from 2024-10-28 11-17-24](https://github.com/user-attachments/assets/9d0d9633-b857-45b4-9217-7d0d1aa8f770) |
    
    r? `````@notriddle`````
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4c3bf15 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#132260 - Zalathar:type-safe-cast, r=compile…

    …r-errors
    
    cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`
    
    In `rustc_codegen_llvm` there are many uses of `.as_ptr().cast()` to convert a string or byte-slice to `*const c_char`, which then gets passed through FFI.
    
    This works, but is fragile, because there's nothing constraining the pointer cast to actually be from `u8` to `c_char`. If the original value changes to something else that has an `as_ptr` method, or the context changes to expect something other than `c_char`, the cast will silently do the wrong thing.
    
    By making the cast more explicit via a helper method, we can be sure that it will either perform the intended cast, or fail at compile time.
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    20a154e View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#132261 - ChrisCho-H:refactor/cleaner-check-…

    …none, r=compiler-errors
    
    refactor: cleaner check to return None
    
    It's very nit change. Refactor to shorten verbose check when returning None for `backend_feature_name`.
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    71601f3 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#132271 - claywilkinson:master, r=tmandry

    Updating Fuchsia platform-support documentation
    
    Updated for changes in the package server workflow.
    
    r? `````@tmandry````` `````@erickt`````
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f788d4c View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#132295 - the8472:remove-randomize-exclusion…

    …1, r=onur-ozkan
    
    fixed wast version was released, remove randomization exemption
    workingjubilee authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0f99a7e View commit details
    Browse the repository at this point in the history