Update compiler_builtins to 0.1.137 and pin it #132433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
rustbot
added
A-testsuite
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Nov 1, 2024
With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 1, 2024
Enable f128 tests on all non-buggy platforms 🎉 With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433 try-job: arm-android try-job: armhf-gnu try-job: i686-gnu try-job: x86_64-apple-1 try-job: i686-mingw try-job: x86_64-msvc-ext
This updates to a new version of builtins that includes [1], which was the last blocker to us enabling `f128` tests on all platforms 🎉. With this update, also change to pinning the version with `=` rather than using the default carat versioning. This is meant to ensure that `compiler-builtins` does not get updated as part of the weekly `Cargo.lock` update, since updates to this crate need to be intentional: changes to rust-lang/rust and rust-lang/compiler-builtins sometimes need to be kept in lockstep, unlike most dependencies, and sometimes these updates can be problematic. [1]: rust-lang/compiler-builtins#624
tgross35
force-pushed
the
update-builtins-pin
branch
from
1efc0e9
to
cb2da01
Compare
workingjubilee
pushed a commit
to tgross35/rust
that referenced
this pull request
Nov 3, 2024
With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 3, 2024
Enable f128 tests on all non-buggy platforms 🎉 With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433 try-job: armhf-gnu try-job: i686-gnu try-job: i686-gnu-nopt try-job: test-various try-job: dist-mips-linux try-job: dist-mips64el-linux
|
I think we can just merge this with #132434 |
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Nov 3, 2024
With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. This patch additionally disables the following: 1. MIPS [2] 2. 32-bit x86 [3] Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433 [2]: llvm/llvm-project#96432 [3]: llvm/llvm-project#77401
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 4, 2024
Enable f128 tests on all non-buggy platforms 🎉 With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433 try-job: test-various try-job: i686-gnu-nopt
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Nov 4, 2024
With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. This patch additionally disables the following: 1. MIPS [2] 2. 32-bit x86 [3] Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433 [2]: llvm/llvm-project#96432 [3]: llvm/llvm-project#77401
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Nov 4, 2024
With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. This patch additionally disables the following: 1. MIPS [2] 2. 32-bit x86 [3] Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433 [2]: llvm/llvm-project#96432 [3]: llvm/llvm-project#77401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to a new version of builtins that includes 1, which was the last blocker to us enabling
f128tests on all platforms 🎉.With this update, also change to pinning the version with
=rather than using the default carat versioning. This is meant to ensure thatcompiler-builtinsdoes not get updated as part of the weeklyCargo.lockupdate, since updates to this crate need to be intentional: changes to rust-lang/rust and rust-lang/compiler-builtins sometimes need to be kept in lockstep, unlike most dependencies, and sometimes these updates can be problematic.