Remove the wasm32-wasi target from rustc
#132562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is the final step in the journey of renaming the historical `wasm32-wasi` target in the Rust compiler to `wasm32-wasip1`. Various steps in this journey so far have been: * 2023-04-03: rust-lang/compiler-team#607 - initial proposal for this rename * 2024-11-27: rust-lang/compiler-team#695 - amended schedule/procedure for rename * 2024-01-29: rust-lang#120468 - initial introduction of `wasm32-wasip1` * 2024-06-18: rust-lang#126662 - warn on usage of `wasm32-wasi` * 2024-11-08: this PR - remove the `wasm32-wasi` target The full transition schedule is in [this comment][comment] and is summarized with: * 2024-05-02: Rust 1.78 released with `wasm32-wasip1` target * 2024-09-05: Rust 1.81 released warning on usage of `wasm32-wasi` * 2025-01-09: Rust 1.84 to be released without the `wasm32-wasi` target This means that support on stable for the replacement target of `wasm32-wasip1` has currently been available for 6 months. Users have already seen warnings on stable for 2 months about usage of `wasm32-wasi` and stable users have another 2 months of warnings before the target is removed from stable. This commit is intended to be the final step in this transition so the source tree should no longer mention `wasm32-wasi` except in historical reference to the older name of the `wasm32-wasip1` target. [comment]: rust-lang#120468 (comment)
rustbot
added
A-compiletest
|
Some changes occurred in src/tools/compiletest cc @jieyouxu These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
alexcrichton
commented
Nov 3, 2024
| @@ -377,7 +377,6 @@ target | std | host | notes | |||
| `thumbv7a-pc-windows-msvc` | ✓ | | | |||
| `thumbv7a-uwp-windows-msvc` | ✓ | | | |||
| `thumbv7neon-unknown-linux-musleabihf` | ? | | Thumb2-mode Armv7-A Linux with NEON, musl 1.2.3 | |||
| [`wasm32-wasip2`](platform-support/wasm32-wasip2.md) | ✓ | | WebAssembly | |||
There was a problem hiding this comment.
This is a bit unrelated to this PR, but I figured while I was here that I could go ahead and update the wasm32-wasip2 target from tier 3 to tier 2 to accurately reflect its status.
|
r? jieyouxu |
jieyouxu
added
O-wasm
|
This also changes the LLVM/LLD target of wasm32-wasip1 to wasm32-wasip1. Is that intended to be done in this PR? |
jieyouxu
approved these changes
Nov 5, 2024
jieyouxu
added
the
relnotes
3 tasks
jieyouxu
added
S-waiting-on-author
|
Ah yes sorry I forgot to call that out but it is indeed intentional. AFAIK it will have no practical change and it matches how @bors: r=jieyouxu |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 6, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#131261 (Stabilize `UnsafeCell::from_mut`) - rust-lang#131405 (bootstrap/codegen_ssa: ship llvm-strip and use it for -Cstrip) - rust-lang#132077 (Add a new `wide-arithmetic` feature for WebAssembly) - rust-lang#132562 (Remove the `wasm32-wasi` target from rustc) - rust-lang#132660 (Remove unused errs.rs file) Failed merges: - rust-lang#131721 (Add new unstable feature `const_eq_ignore_ascii_case`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 6, 2024
Rollup merge of rust-lang#132562 - alexcrichton:remove-wasm32-wasi, r=jieyouxu Remove the `wasm32-wasi` target from rustc This commit is the final step in the journey of renaming the historical `wasm32-wasi` target in the Rust compiler to `wasm32-wasip1`. Various steps in this journey so far have been: * 2023-04-03: rust-lang/compiler-team#607 - initial proposal for this rename * 2024-11-27: rust-lang/compiler-team#695 - amended schedule/procedure for rename * 2024-01-29: rust-lang#120468 - initial introduction of `wasm32-wasip1` * 2024-06-18: rust-lang#126662 - warn on usage of `wasm32-wasi` * 2024-11-08: this PR - remove the `wasm32-wasi` target The full transition schedule is in [this comment][comment] and is summarized with: * 2024-05-02: Rust 1.78 released with `wasm32-wasip1` target * 2024-09-05: Rust 1.81 released warning on usage of `wasm32-wasi` * 2025-01-09: Rust 1.84 to be released without the `wasm32-wasi` target This means that support on stable for the replacement target of `wasm32-wasip1` has currently been available for 6 months. Users have already seen warnings on stable for 2 months about usage of `wasm32-wasi` and stable users have another 2 months of warnings before the target is removed from stable. This commit is intended to be the final step in this transition so the source tree should no longer mention `wasm32-wasi` except in historical reference to the older name of the `wasm32-wasip1` target. [comment]: rust-lang#120468 (comment)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 7, 2024
Since [1], the `wasm32-wasi` target is no longer supported (replaced by `wasm32-wasip1` and `wasm32-wasip2`). This has made it into the latest nightly, so remove it from our testing. [1]: rust-lang/rust#132562
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 7, 2024
Since [1], the `wasm32-wasi` target is no longer supported (replaced by `wasm32-wasip1` and `wasm32-wasip2`). This has made it into the latest nightly, so remove it from our testing. [1]: rust-lang/rust#132562 (backport <rust-lang#4013>) (cherry picked from commit a4d3ca8)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 7, 2024
Since [1], the `wasm32-wasi` target is no longer supported (replaced by `wasm32-wasip1` and `wasm32-wasip2`). This has made it into the latest nightly, so remove it from our testing. [1]: rust-lang/rust#132562 (backport <rust-lang#4013>) (cherry picked from commit a4d3ca8)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 7, 2024
Since [1], the `wasm32-wasi` target is no longer supported (replaced by `wasm32-wasip1` and `wasm32-wasip2`). This has made it into the latest nightly, so remove it from our testing. [1]: rust-lang/rust#132562 (backport <rust-lang#4013>) (cherry picked from commit a4d3ca8)
|
Just a note here: our builds pin nightlies based on LLVM updates, since this impacts compatibility with Xcode and other tools in our pipeline that run LTO on our C++/Rust mixed binaries. We are currently limited to nightlies that support LLVM 17, which is the version in the current Xcode release. It appears that LLVM 18 landed on Feb 13, 2024: eaff1af Meanwhile, This means that there is no nightly version that currently supports both LLVM 17 and |
|
@sffc is it possible to configure your CI to work around this? For example using a different compiler for wasm than for native? |
|
Yes it can be worked-around with CI configs, but that's exactly why it is a pain point. It would have been easier if the transition period between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the final step in the journey of renaming the historical
wasm32-wasitarget in the Rust compiler towasm32-wasip1. Various steps in this journey so far have been:wasm32-wasitarget towasm32-wasi-preview1compiler-team#607 - initial proposal for this renamewasm32-wasicompiler-team#695 - amended schedule/procedure for renamewasm32-wasip1target to rustc #120468 - initial introduction ofwasm32-wasip1wasm32-wasi#126662 - warn on usage ofwasm32-wasiwasm32-wasitargetThe full transition schedule is in this comment and is summarized with:
wasm32-wasip1targetwasm32-wasiwasm32-wasitargetThis means that support on stable for the replacement target of
wasm32-wasip1has currently been available for 6 months. Users have already seen warnings on stable for 2 months about usage ofwasm32-wasiand stable users have another 2 months of warnings before the target is removed from stable.This commit is intended to be the final step in this transition so the source tree should no longer mention
wasm32-wasiexcept in historical reference to the older name of thewasm32-wasip1target.