Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13247: get make check-stage1 working again #13260

Merged
merged 3 commits into from
Apr 5, 2014

Commits on Apr 2, 2014

  1. Configuration menu
    Copy the full SHA
    2cddd68 View commit details
    Browse the repository at this point in the history
  2. Two fixes to get make check-stage1 working.

    1. Fix a long-standing typo in the makefile: the relevant
       CTEST_NAME here is `rpass-full` (with a dash), not
       `rpass_full`.
    
    2. The rpass-full tests depend on the complete set of target
       libraries.  Therefore, the rpass-full tests need to use
       the dependencies held in the CSREQ-prefixed variable, not
       the TLIBRUSTC_DEFAULT-prefixed variable.
    pnkfelix committed Apr 2, 2014
    4 Configuration menu
    Copy the full SHA
    3cbd98e View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2014

  1. Fix android problems with newly fixed rpass-full variable definition.

    First, documented the existing `CTEST_DISABLE_$(TEST_GROUP)` pattern
    for conditionally disabling tests based on missing host features.
    
    Added variant of above, `CTEST_DISABLE_NONSELFHOST_$(TEST_GROUP)`,
    which is only queried in contexts where the target is not on the
    CFG_HOST list (which I interpret as the list of targets that our host
    can compatibly emulate; e.g. the example that i686 and x86_64 can in
    theory run each others' tests).
    
    Driveby fix: Remove redundant copy of
    check-stage$(1)-T-$(2)-H-$(3)-$(4)-exec dependency declaration.
    pnkfelix committed Apr 5, 2014
    5 Configuration menu
    Copy the full SHA
    4edf7b8 View commit details
    Browse the repository at this point in the history