Add documentation on ast::Attribute
#132642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
|
cc @jdonszelmann who's reworking our attribute infra |
|
this parsing code (which you added docs to) is likely going to disappear in the near future, in favor for a properly documented parser I have locally. Feel free to merge this for now, but it's likely short lived |
lqd
reviewed
Nov 5, 2024
GuillaumeGomez
force-pushed
the
attr-docs
branch
from
ddf12dc to
3300960
Compare
compiler-errors
approved these changes
Nov 5, 2024
|
I guess it doesn't hurt to add this 🤷 sorry for any ensuing merge conflicts @jdonszelmann @bors r+ rollup |
bors
added
S-waiting-on-bors
|
no worries, I agree actually 👍 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#132259 (rustc_codegen_llvm: Add a new 'pc' option to branch-protection) - rust-lang#132409 (CI: switch 7 linux jobs to free runners) - rust-lang#132498 (Suggest fixing typos and let bindings at the same time) - rust-lang#132524 (chore(style): sync submodule exclusion list between tidy and rustfmt) - rust-lang#132567 (Properly suggest `E::assoc` when we encounter `E::Variant::assoc`) - rust-lang#132571 (add const_eval_select macro to reduce redundancy) - rust-lang#132637 (Do not filter empty lint passes & re-do CTFE pass) - rust-lang#132642 (Add documentation on `ast::Attribute`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 6, 2024
Rollup merge of rust-lang#132642 - GuillaumeGomez:attr-docs, r=compiler-errors Add documentation on `ast::Attribute` I was working again with attributes in clippy recently and I often find myself in need to read the source code to ensure it's doing what I want. Instead, a bit of documentation would allow me (and hopefully others) to skip this step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working again with attributes in clippy recently and I often find myself in need to read the source code to ensure it's doing what I want.
Instead, a bit of documentation would allow me (and hopefully others) to skip this step.