Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #132943

Merged
merged 40 commits into from
Nov 12, 2024
Merged

Rollup of 8 pull requests #132943

merged 40 commits into from
Nov 12, 2024

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    8071cbd View commit details
    Browse the repository at this point in the history
  2. Merge pull request rust-lang#18473 from Veykril/push-xnlzukoqttvz

    Render extern blocks in `file_structure`
    Veykril authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    aa59ac3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5cbfb74 View commit details
    Browse the repository at this point in the history
  4. Merge pull request rust-lang#18475 from Veykril/push-zkvkpxttozup

    Support new #[rustc_intrinsic] attribute and fallback bodies
    Veykril authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    acfacff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1330cd1 View commit details
    Browse the repository at this point in the history
  6. Merge pull request rust-lang#18477 from lnicola/rm-ap-text-edit

    minor: Don't try to auto-publish text-edit
    lnicola authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    56f46c2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    59ee3bd View commit details
    Browse the repository at this point in the history
  8. Merge pull request rust-lang#18478 from lnicola/triagebot-transfer

    minor: Enable triagebot `transfer` feature
    lnicola authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    69437d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    80df05b View commit details
    Browse the repository at this point in the history
  2. Refactor hir::Trait's existing items_with_supertraits(…) method b…

    …ased on new `all_supertraits(…)` method
    regexident committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    fa393dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de30d7d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d5dec8a View commit details
    Browse the repository at this point in the history
  5. editors/code: Change minimum VS Code from 1.78 to 1.83

    It's been a year since we last bumped this (see rust-lang#15904), and VS Code
    1.83 is the first version that supports LSP 3.17.5 (via
    vscode-languageclient 9.0.1).
    
    https://code.visualstudio.com/updates/v1_83#_language-server-protocol
    Wilfred committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    cd6ddca View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    902a2c5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request rust-lang#18490 from ShoyuVanilla/dyn-compat-rename

    minor: Rename `dyn compatible` to `dyn-compatible`
    lnicola authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    668f388 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0172638 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge pull request rust-lang#18486 from Wilfred/update_minimum_vscode

    editors/code: Change minimum VS Code from 1.78 to 1.83
    lnicola authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f9d7f6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef8a0c0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request rust-lang#18493 from Master-Hash/fix-code-debugeng…

    …ine-config
    
    editors/code: Update supported debug engines in config
    lnicola authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0aa0bd2 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Replace with C-Architecture

    samestep committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    29f8426 View commit details
    Browse the repository at this point in the history
  2. Merge pull request rust-lang#18492 from samestep/docs-dev-no-design-l…

    …abel
    
    Replace Design label with C-Architecture
    lnicola authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    a118777 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Merge pull request rust-lang#18482 from regexident/hir_trait_supertra…

    …its_accessors
    
    internal: Add public `direct_supertraits(…)` & `all_supertraits(…)` accessor methods to `hir::Trait`
    lnicola authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c2ffafd View commit details
    Browse the repository at this point in the history
  2. Generalize NonNull::from_raw_parts per ACP362

    I did the raw pointers in 125701, but apparently forgot `NonNull`.
    scottmcm committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fb26ba8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e04acff View commit details
    Browse the repository at this point in the history
  4. Use completion item indices instead of property matching when searchi…

    …ng for the completion item to resolve
    SomeoneToIgnore committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    572ae69 View commit details
    Browse the repository at this point in the history
  5. Update the file hash

    SomeoneToIgnore committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e646263 View commit details
    Browse the repository at this point in the history
  6. Merge pull request rust-lang#18503 from SomeoneToIgnore/kb/better-res…

    …olve-indexing
    
    Use completion item indices instead of property matching when searching for the completion item to resolve
    lnicola authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    61dba02 View commit details
    Browse the repository at this point in the history
  7. Update grammar in std::cell docs.

    Using "having" in both the leading sentence and the bullets is unnecessary.
    It makes it read as "it is only possible to have having several immutable...".
    rcorre committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0d3a58e View commit details
    Browse the repository at this point in the history
  8. remove attributes from generics in built-in derive macros

    add a test
    
    add github issue link to description of the test
    
    replace new ThinVec with clear()
    
    Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>
    PonasKovas and fmease committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7c0a7f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    d128c80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bea0148 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ba72db View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#132651 - PonasKovas:master, r=fmease

    Remove attributes from generics in built-in derive macros
    
    Related issue rust-lang#132561
    
    Removes all attributes from generics in the expanded implementations of built-in derive macros.
    matthiaskrgr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b18ee98 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#132668 - ehuss:yield-gate-2024, r=davidtwco

    Feature gate yield expressions not in 2024
    
    This changes it so that yield expressions are no longer allowed in the 2024 edition without a feature gate. We are currently only reserving the `gen` keyword in the 2024 edition, and not allowing anything else to be implicitly enabled by the edition.
    
    In practice this doesn't have a significant difference since yield expressions can't really be used outside of coroutines or gen blocks, which have their own feature gates. However, it does affect what is accepted pre-expansion, and I would feel more comfortable not allowing yield expressions.
    
    I believe the stabilization process for gen blocks or coroutines will not need to check the edition here, so this shouldn't ever be needed.
    matthiaskrgr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1dd975b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#132771 - ismailarilik:test/configure/cover-…

    …parse-args-in-src-bootstrap-configure-py, r=onur-ozkan
    
    test(configure): cover `parse_args` in `src/bootstrap/configure.py`
    
    I was reading `src/bootstrap/configure.py` and `parse_args` function there seems complex. So I added some tests to cover it and prevent regressions.
    matthiaskrgr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3a0cc81 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#132895 - scottmcm:generalize-nonnull-from-r…

    …aw-parts, r=ibraheemdev
    
    Generalize `NonNull::from_raw_parts` per ACP362
    
    I did the raw pointers in rust-lang#125701, but apparently forgot `NonNull`.
    
    cc rust-lang/libs-team#362
    matthiaskrgr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    72c6268 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#132914 - rcorre:cell-grammar, r=tgross35

    Update grammar in std::cell docs.
    
    Using "having" in both the leading sentence and the bullets is unnecessary.
    It makes it read as "it is only possible to have having several immutable...".
    matthiaskrgr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    87d5faf View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#132927 - BoxyUwU:consolidate_type_system_co…

    …nst_eval, r=compiler-errors
    
    Consolidate type system const evaluation under `traits::evaluate_const`
    
    Part of rust-lang#130704
    
    Fixes rust-lang#128232
    Fixes rust-lang#118545
    
    Removes `ty::Const::{normalize_internal, eval_valtree}` and `InferCtxt::(try_)const_eval_resolve`, consolidating the associated logic into `evaluate_const` in `rustc_trait_selection`. This results in an API for `ty::Const` that is free of any normalization/evaluation functions that would be incorrect to use under `min_generic_const_args`/`associated_const_equality`/`generic_const_exprs` or, more generally, that would be incorrect to use in the presence of generic type system constants.
    
    Moving this logic to `rustc_trait_selection` and out of `rustc_middle` is also a pre-requisite for ensuring that we do not evaluate constants whose where clauses do not hold.
    
    From this point it should be relatively simple (hah) to implement more complex normalization of type system constants such as: checking wf'ness before invoking CTFE machinery, or being able to normalize const aliases that still refer to generic parameters.
    
    r? `@compiler-errors`
    matthiaskrgr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ea61714 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#132935 - compiler-errors:arg-math, r=nnethe…

    …rcote
    
    Make sure to ignore elided lifetimes when pointing at args for fulfillment errors
    
    See the comment I left in the code.
    
    ---
    
    If we have something like:
    
    ```
    fn foo<'a, T: 'a + BoundThatIsNotSatisfied>() {}
    ```
    
    And the user turbofishes just the type args:
    
    ```
    foo::<()>();
    ```
    
    Then if we try pointing at `()` (i.e. the type argument for `T`), we don't actually consider the possibility that the lifetimes may have been left out of the turbofish. We try indexing incorrectly into the HIR args, and bail on the suggestion.
    matthiaskrgr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9a4a954 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#132941 - lnicola:sync-from-ra2, r=lnicola

    Subtree update of `rust-analyzer`
    
    r? `@ghost`
    matthiaskrgr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    38c2db4 View commit details
    Browse the repository at this point in the history