Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy: Distinguish between two different meanings of "style file" #133405

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Nov 24, 2024

This file contains code that uses “style file” to mean “CSS file”, and other code that uses “style file” to mean “this file, which implements the style checker”.

That's very confusing, so it's easier to just say CSS file or this file as appropriate.

No functional change.

@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 24, 2024
@jieyouxu
Copy link
Member

r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned Mark-Simulacrum Nov 24, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 24, 2024

📌 Commit 2134a7e has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#133300 (inject_panic_runtime(): Avoid double negation for 'any non rlib')
 - rust-lang#133301 (Add code example for `wrapping_neg` method for signed integers)
 - rust-lang#133371 (remove is_trivially_const_drop)
 - rust-lang#133389 (Stabilize `const_float_methods`)
 - rust-lang#133398 (rustdoc: do not call to_string, it's already impl Display)
 - rust-lang#133405 (tidy: Distinguish between two different meanings of "style file")

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3ccacef into rust-lang:master Nov 24, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2024
Rollup merge of rust-lang#133405 - Zalathar:style-file, r=jieyouxu

tidy: Distinguish between two different meanings of "style file"

This file contains code that uses “style file” to mean “CSS file”, and other code that uses “style file” to mean “this file, which implements the style checker”.

That's very confusing, so it's easier to just say *CSS file* or *this file* as appropriate.

No functional change.
@rustbot rustbot added this to the 1.85.0 milestone Nov 24, 2024
@Zalathar Zalathar deleted the style-file branch November 24, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants