-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build rustc
with 1 CGU on aarch64-apple-darwin
#133747
Conversation
@bors try |
build `rustc` with 1 CGU on `aarch64-apple-darwin` Distribute `aarch64-apple-darwin` artifacts built with `rust.codegen-units=1`, like we already do on Linux/Windows/macOS Intel. 1. Performance results (only wall-time on mac as usual) - I only did some `ripgrep` check builds (the revision from rustc-perf), because we had noticeable wins in wall-time there back then on linux. It's a ~2-4% (mostly 3%) improvement on local builds, and will re-check with CI artifacts once they're available. 2. Effects on code size on `aarch64-apple-darwin`: - before: TODO, 165MB or so - after: TODO, 142MB or so 3. Effects on CI - TODO r? `@ghost` try-job: dist-aarch64-apple
It's actually a good point that 1 CGU might save us a lot of bandwidth costs, even if it's not such a big compile-time win 😆 Although we need to be wary of the CI build cost too, of course. |
Yes that's why I'm preparing all these stats. Though I'd take a """free""" 3% win any day ^^ |
☀️ Try build successful - checks-actions |
@bors try |
build `rustc` with 1 CGU on `aarch64-apple-darwin` Distribute `aarch64-apple-darwin` artifacts built with `rust.codegen-units=1`, like we already do on Linux/Windows/macOS Intel. 1. Performance results (only wall-time on mac as usual) - I only did some `ripgrep` check builds (the revision from rustc-perf), because we had noticeable wins in wall-time there back then on linux. It's a ~2-4% (mostly 3%) improvement on local builds, and will re-check with CI artifacts once they're available. 2. Effects on code size on `aarch64-apple-darwin`: - before: TODO, 165MB or so - after: TODO, 142MB or so 3. Effects on CI - TODO r? `@ghost` try-job: dist-aarch64-apple
☀️ Try build successful - checks-actions |
Alright, this looks good enough for review, r? infra |
Before the duration was usually around 1h 20m, I think that slight increase is fine, especially since this is running on a free runner. Nice results! @bors r+ rollup=never (setting rollup=never in case this caused some compilation regressions down the line) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (42b4b9c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.0%, secondary -3.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 767.322s -> 768.021s (0.09%) |
Distribute
aarch64-apple-darwin
artifacts built withrust.codegen-units=1
, like we already do on Linux/Windows/macOS Intel.ripgrep
check builds (the revision from rustc-perf), because we had noticeable wins in wall-time there back then on linux. It's a ~2-4% (mostly 3%) improvement on local builds.aarch64-apple-darwin
: it's a 13.24% reduction onlibrustc_driver.dylib