Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new intrinsic declaration #134013

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Adds new intrinsic declaration #134013

merged 1 commit into from
Dec 9, 2024

Conversation

BLANKatGITHUB
Copy link
Contributor

This pr is for #132735 removes removes extern "intrinsic"

I think its the last block of this file and was kind of asking for advice how to handle other files as mentioned in the issue .

@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 7, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2024

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @rust-lang/wg-const-eval

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin
Copy link
Member

saethlin commented Dec 8, 2024

I think its the last block of this file and was kind of asking for advice how to handle other files as mentioned in the issue .

Are you asking about the changes to the compiler?

@BLANKatGITHUB
Copy link
Contributor Author

I think its the last block of this file and was kind of asking for advice how to handle other files as mentioned in the issue .

Are you asking about the changes to the compiler?

yes

@saethlin
Copy link
Member

saethlin commented Dec 8, 2024

For this PR, squash the commits together and then it's good.

I'll post some guidance on the issue about what to do (in a few hours).

@BLANKatGITHUB
Copy link
Contributor Author

For this PR, squash the commits together and then it's good.

I'll post some guidance on the issue about what to do (in a few hours).

thanks

@BLANKatGITHUB
Adds new intrinsic declaration
292fd0f 
changes old intrinsic to new declaration
@saethlin
Copy link
Member

saethlin commented Dec 8, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 8, 2024

📌 Commit 292fd0f has been approved by saethlin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2024
@RalfJung
Copy link
Member

RalfJung commented Dec 8, 2024 via email

@matthiaskrgr matthiaskrgr mentioned this pull request Dec 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2024
@bors
Auto merge of rust-lang#134039 - matthiaskrgr:rollup-ix8kdg1, r=matth…
e888a15 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133424 (Parse guard patterns)
 - rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
 - rust-lang#133993 (Fix: typo in E0751 error explanation)
 - rust-lang#134013 (Adds new intrinsic declaration)
 - rust-lang#134020 (Remove unnecessary `int_type_width_signed` function)
 - rust-lang#134024 (Advent of `tests/ui` (misc cleanups and improvements) [2/N])
 - rust-lang#134038 (deps: Update psm)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2024
@bors
Auto merge of rust-lang#134039 - matthiaskrgr:rollup-ix8kdg1, r=matth…
df5b8e3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133424 (Parse guard patterns)
 - rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
 - rust-lang#133993 (Fix: typo in E0751 error explanation)
 - rust-lang#134013 (Adds new intrinsic declaration)
 - rust-lang#134020 (Remove unnecessary `int_type_width_signed` function)
 - rust-lang#134024 (Advent of `tests/ui` (misc cleanups and improvements) [2/N])
 - rust-lang#134038 (deps: Update psm)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fe5f5fd into rust-lang:master Dec 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024
@rust-timer
Unrolled build for rust-lang#134013
d514719 
Rollup merge of rust-lang#134013 - BLANKatGITHUB:intrinsic, r=saethlin

Adds new intrinsic declaration

This pr is for rust-lang#132735 removes removes `extern "intrinsic"`

I think its the last block of this file and was kind of asking for advice how to handle other files as mentioned in the issue .
@BLANKatGITHUB
Copy link
Contributor Author

@RalfJung well can I port
./library/core/src/ffi/va_list.rs ./library/core/src/intrinsics/simd.rs as they also have extern "rust-intrinsic" and are last 2 files of library with the declaration before porting tests?

@RalfJung
Copy link
Member

RalfJung commented Dec 11, 2024 via email

@BLANKatGITHUB
Copy link
Contributor Author

Ok so like should I port those va_list or leave them for now?

@RalfJung
Copy link
Member

Please do port them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
7 participants
@BLANKatGITHUB @rustbot @rust-log-analyzer @saethlin @bors @RalfJung @Amanieu