Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: std::io::ErrorKind::CrossesDevices is finally stable #134074

Merged
merged 1 commit into from
Jan 11, 2025
Merged

bootstrap: std::io::ErrorKind::CrossesDevices is finally stable #134074

merged 1 commit into from
Jan 11, 2025

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Dec 9, 2024 •
edited
Loading

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 9, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Dec 9, 2024

r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned albertlarsan68 Dec 9, 2024
@GrigorenkoPV
Copy link
Contributor Author

GrigorenkoPV commented Jan 9, 2025 •
edited
Loading

#135268 has landed, so
@rustbot label -S-blocked
@rustbot ready
cc @jieyouxu

@rustbot rustbot removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 9, 2025
@GrigorenkoPV GrigorenkoPV force-pushed the bootstrap-io-error-more branch from c2acbe6 to 4ba139d Compare January 9, 2025 17:24
@jieyouxu
Copy link
Member

jieyouxu commented Jan 9, 2025

Cool. I'll r+ after PR CI is green.

@jieyouxu jieyouxu added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2025
@jieyouxu
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 10, 2025

📌 Commit 4ba139d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2025
@jhpratt jhpratt mentioned this pull request Jan 11, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2025
@bors
Auto merge of rust-lang#135357 - jhpratt:rollup-gs00yt3, r=jhpratt
ce55b20 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#134074 (bootstrap: `std::io::ErrorKind::CrossesDevices` is finally stable)
 - rust-lang#135236 (Update a bunch of library types for MCP807)
 - rust-lang#135301 (re-add a warning for old master branch, but with much simpler logic)
 - rust-lang#135324 (Initial fs module for uefi)
 - rust-lang#135326 (support target specific `optimized-compiler-builtins`)
 - rust-lang#135347 (Use `NonNull::without_provenance` within the standard library)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bd81023 into rust-lang:master Jan 11, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 11, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2025
@rust-timer
Unrolled build for rust-lang#134074
de3ae45 
Rollup merge of rust-lang#134074 - GrigorenkoPV:bootstrap-io-error-more, r=jieyouxu

bootstrap: `std::io::ErrorKind::CrossesDevices` is finally stable
@GrigorenkoPV GrigorenkoPV deleted the bootstrap-io-error-more branch January 11, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GrigorenkoPV @rustbot @rust-log-analyzer @jieyouxu @bors @albertlarsan68