Stabilize num_midpoint_signed
feature
#134340
Open
+4
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes that we stabilize the signed variants of
iN::midpoint
, the operation is equivalent to doing(a + b) / 2
in a sufficiently large number.The stabilized API surface would be:
T-libs-api previously stabilized the unsigned (and float) variants in #131784, the signed variants were left out because of the rounding that should be used in case of negative midpoint.
This stabilization proposal proposes that we round towards zero because:
(a + b) / 2
in a sufficiently-large number always truemidpoint(-a, -b)
==-midpoint(a, b)
always truemidpoint(a as f64, b as f64) as i64
midpoint
as a replacement for(a + b) / 2
expressions (which we may want to do as a future work given the 21.2k hits on GitHub Search)@scottmcm mentioned a drawback in #132191 (comment):
Which I think is outweigh by the advantages cited above.
Closes #110840
cc @rust-lang/libs-api
cc @scottmcm
r? @dtolnay