Use more precise span when reporting semicolon hint #13435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
r? |
|
|
||
| fn foo() -> ~str { //~ ERROR not all control paths return a value | ||
| format!("Hello {:s}", | ||
| "world"); |
There was a problem hiding this comment.
If you put this semicolon on its own line, the test will test that it's exactly the semicolon:
format!("Hello {}",
"world")
; //~ NOTE consider removing this semcolonThere was a problem hiding this comment.
Hmm? I don't follow.
There was a problem hiding this comment.
The current test will pass if the span points to the ) or to the "world", since it's entirely line-based. By putting the ; on its own line, then you're testing that exactly the semicolon gets the span.
|
Comments addressed. r? @huonw |
When reporting "consider removing this semicolon" hint message, the offending semicolon may come from macro call site instead of macro itself. Using the more appropriate span makes the hint more helpful. Closes rust-lang#13428.
bors
added a commit
that referenced
this pull request
Apr 22, 2014
When reporting "consider removing this semicolon" hint message, the offending semicolon may come from macro call site instead of macro itself. Using the more appropriate span makes the hint more helpful. Closes #13428.
notriddle
pushed a commit
to notriddle/rust
that referenced
this pull request
Nov 10, 2022
…re-pt3, r=Veykril Migrate assists to format args captures, part 3 Continuation of rust-lang/rust-analyzer#13379 Migrates: - `inline_call` - `inline_local_variable` - `introduce_named_lifetime` - `merge_match_arms` - `move_from_mod_rs` - `move_guard` - `move_module_to_file` - `move_to_mod_rs` - `number_representation` - `qualify_method_call` - `qualify_path` - `raw_string` - `remove_dbg` - `replace_derive_with_manual_impl` - `replace_or_with_or_else` - `replace_turbofish_with_explicit_type` - `unwrap_tuple` - `wrap_return_type_in_result`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reporting "consider removing this semicolon" hint message, the
offending semicolon may come from macro call site instead of macro
itself. Using the more appropriate span makes the hint more helpful.
Closes #13428.