Rollup of 7 pull requests #134439

matthiaskrgr · 2024-12-17T21:34:45Z

Successful merges:

Add a range argument to vec.extract_if #133265 (Add a range argument to vec.extract_if)
Promote powerpc64le-unknown-linux-musl to tier 2 with host tools #133801 (Promote powerpc64le-unknown-linux-musl to tier 2 with host tools)
coverage: Dismantle map_data.rs by moving its responsibilities elsewhere #134323 (coverage: Dismantle map_data.rs by moving its responsibilities elsewhere)
An octuple of polonius fact generation cleanups #134378 (An octuple of polonius fact generation cleanups)
Regression test for RPIT inheriting lifetime from projection #134408 (Regression test for RPIT inheriting lifetime from projection)
bootstrap: use specific-purpose ui test path for test_valid self-test #134423 (bootstrap: use specific-purpose ui test path for test_valid self-test)
Fix typo in uint_macros.rs #134426 (Fix typo in uint_macros.rs)

Failed merges:

Pass FnAbi to find_mir_or_eval_fn #133103 (Pass FnAbi to find_mir_or_eval_fn)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

MCP: rust-lang/compiler-team#803 Signed-off-by: Jens Reidel <adrian@travitia.xyz>

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

…usl.md Co-authored-by: famfo <famfo@famfo.xyz>

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

- remove dependency on `TypeChecker` - move to legacy fact generation module

- remove dependency on `TypeChecker` - move to legacy fact generation module - remove polonius module from liveness

- remove dependency on `TypeChecker` - move to legacy fact generation module - group facts emitted during typeck together

also remove a useless trace

- integrate it within existing fact generation instead of being called in typeck - simplify access fact extraction - also remove single use fact emit functions in root fact generation

- integrate into `emit_facts` and remove from typeck

- use a consistent name for `TypeChecker`, which is usually referred to as `typeck` - remove an incorrect doc comment - remove a single-use local

- fix names - fix ordering of arguments

since drain-on-drop behavior was removed those bounds no longer serve a purpose

The checks in `is_eligible_for_coverage` include `is_fn_like`, but will also exclude various function-like things that cannot possibly have coverage instrumentation.

This patch dismantles what was left of `FunctionCoverage` in `map_data.rs`, replaces `function_coverage_map` with a set, and overhauls how we prepare covfun records for unused functions.

I wanted to move some ui tests around, which broke `test_valid` since it was referencing a non-specific-purpose ui test.

Add a range argument to vec.extract_if tracking issue: rust-lang#43244 This adds the range argument requested in rust-lang#43244 (comment)

…x-musl-tier-2, r=jieyouxu,Urgau,Kobzol Promote powerpc64le-unknown-linux-musl to tier 2 with host tools MCP: rust-lang/compiler-team#803 I'm using crosstool-ng for building a toolchain because GCC 9 from `musl-toolchain.sh` has float ABI issues (?) and can't compile LLVM, and writing a crosstool-ng config for a target feels less hacky than yet another target specific shell script. I also defined a kernel version, since there wasn't one specified before. If a lower version is desired, just let me know. I also tried to match the rust configure args with the loongarch64 musl tier 2 target. The resulting compiler works fine, built with `DEPLOY=1 ./src/ci/docker/run.sh dist-powerpc64le-linux` and tested on Alpine Linux in a VM and on a bare metal POWER8 machine: ``` qemu-ppc64le:/tmp/rust-nightly-powerpc64le-unknown-linux-musl$ ash install.sh install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh install: installing component 'rustc' install: installing component 'rust-std-powerpc64le-unknown-linux-musl' install: installing component 'cargo' install: installing component 'rustfmt-preview' install: installing component 'rls-preview' install: installing component 'rust-analyzer-preview' install: installing component 'llvm-tools-preview' install: installing component 'clippy-preview' install: installing component 'miri-preview' install: installing component 'rust-analysis-powerpc64le-unknown-linux-musl' install: installing component 'llvm-bitcode-linker-preview' install: WARNING: failed to run ldconfig. this may happen when not installing as root. run with --verbose to see the error rust installed. qemu-ppc64le:~$ echo 'fn main() { println!("hello world"); }' > test.rs qemu-ppc64le:~$ rustc test.rs qemu-ppc64le:~$ ./test hello world qemu-ppc64le:~$ file test test: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, BuildID[sha1]=596ee6abf9add487ebc54fb71c2076fb6faea013, with debug_info, not stripped ``` try-job: dist-powerpc64le-linux

…youxu coverage: Dismantle `map_data.rs` by moving its responsibilities elsewhere This is a series of incremental changes that combine to let us get rid of `coverageinfo/map_data.rs`, by moving all of its responsibilities into more appropriate places. Some of the notable consequences are: - We once again build the per-CGU file table on the fly while preparing individual covfun records, instead of building the whole table up-front. The up-front approach was introduced by rust-lang#117042 to work around various other problems in generating the covmap/covfun records, but subsequent cleanups have made that approach no longer necessary. - Expression conversion and mapping-region conversion are now performed directly in `mapgen::covfun`, which should make future changes easier. - We no longer insert unused function instances into the same map that is also used to track used function instances. This helps to decouple the handling of used vs unused functions. --- There should be no meaningful change to compiler output. The file table is no longer sorted, because reordering it would invalidate the file indices stored in individual covfun records, but the table order should still be deterministic (albeit arbitrary). There are some subsequent cleanups that I intend to investigate, but this is enough change for one PR.

…kh726 An octuple of polonius fact generation cleanups This PR is extracted from rust-lang#134268 for easier review and contains its first 8 commits. They have already been reviewed by ````@jackh726```` over there. r? ````@jackh726````

…=compiler-errors Regression test for RPIT inheriting lifetime from projection Regression test to close rust-lang#51525

…nur-ozkan bootstrap: use specific-purpose ui test path for `test_valid` self-test I wanted to move some ui tests around in rust-lang#134418, which broke `test_valid` since it was referencing two non-specific-purpose ui tests. This PR instead adds two dummy tests under `tests/ui/bootstrap/self-test/`, for that purpose specifically. r? bootstrap

Fix typo in uint_macros.rs

matthiaskrgr · 2024-12-17T21:34:56Z

@bors r+ rollup=never p=7

bors · 2024-12-17T21:34:59Z

📌 Commit 3b0df8c has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-12-18T00:15:01Z

⌛ Testing commit 3b0df8c with merge 52890e8...

bors · 2024-12-18T02:55:30Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 52890e8 to master...

rust-timer · 2024-12-18T04:13:18Z

Finished benchmarking commit (52890e8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[3.4%, 3.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 3.7%, secondary 5.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[3.7%, 3.7%]	1
Regressions ❌ (secondary)	5.8%	[5.7%, 5.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.7%	[3.7%, 3.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.759s -> 768.784s (-0.13%)
Artifact size: 330.32 MiB -> 330.32 MiB (0.00%)

Gelbpunkt and others added 30 commits December 6, 2024 04:35

Promote powerpc64le-unknown-linux-musl to tier 2 with host tools

68ce659

MCP: rust-lang/compiler-team#803 Signed-off-by: Jens Reidel <adrian@travitia.xyz>

Fix markdown link

3e3ee4c

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

Update src/doc/rustc/src/platform-support/powerpc64le-unknown-linux-m…

8bb0fd5

…usl.md Co-authored-by: famfo <famfo@famfo.xyz>

Move dist-powerpc64le-linux to job-linux-4c-largedisk

286de9f

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

clean up emit_access_facts

2fd4438

- remove dependency on `TypeChecker` - move to legacy fact generation module

clean up emit_drop_facts

9d8f58a

- remove dependency on `TypeChecker` - move to legacy fact generation module - remove polonius module from liveness

clean up translate_outlives_facts

afbe101

- remove dependency on `TypeChecker` - move to legacy fact generation module - group facts emitted during typeck together

use let else more consistently in fact generation

5486857

also remove a useless trace

simplify emit_access_facts and fact generation

1740a5f

- integrate it within existing fact generation instead of being called in typeck - simplify access fact extraction - also remove single use fact emit functions in root fact generation

simplify emit_outlives_facts

2024c5d

- integrate into `emit_facts` and remove from typeck

refactor type_check module slightly

7ad1f5b

- use a consistent name for `TypeChecker`, which is usually referred to as `typeck` - remove an incorrect doc comment - remove a single-use local

improve consistency within fact gen

8562497

- fix names - fix ordering of arguments

Add a range argument to vec.extract_if

ab6ad1a

remove bounds from vec and linkedlist ExtractIf

03f1b73

since drain-on-drop behavior was removed those bounds no longer serve a purpose

update uses of extract_if in the compiler

fe52150

remove obsolete comment and pub(super) visibility

44790c4

coverage: Use is_eligible_for_coverage to filter unused functions

fe412af

The checks in `is_eligible_for_coverage` include `is_fn_like`, but will also exclude various function-like things that cannot possibly have coverage instrumentation.

coverage: Build the global file table on the fly

154fae1

coverage: Pull expression conversion out of map_data.rs

252276a

coverage: Pull region conversion out of map_data.rs

527f812

coverage: Pull function source hash out of map_data.rs

d34c365

coverage: Track used functions in a set instead of a map

541d4e8

This patch dismantles what was left of `FunctionCoverage` in `map_data.rs`, replaces `function_coverage_map` with a set, and overhauls how we prepare covfun records for unused functions.

Regression test for RPIT inheriting lifetime

a7f61ca

bootstrap: use specific-purpose ui test path

13e8313

I wanted to move some ui tests around, which broke `test_valid` since it was referencing a non-specific-purpose ui test.

Fix typo in uint_macros.rs

c482b31

Rollup merge of rust-lang#133265 - the8472:extract-if-ranges, r=cuviper

938742e

Add a range argument to vec.extract_if tracking issue: rust-lang#43244 This adds the range argument requested in rust-lang#43244 (comment)

Rollup merge of rust-lang#134408 - rmehri01:rpit-inherits-lifetime, r…

53635e5

…=compiler-errors Regression test for RPIT inheriting lifetime from projection Regression test to close rust-lang#51525

matthiaskrgr added 2 commits December 17, 2024 22:34

Rollup merge of rust-lang#134426 - hkBst:patch-3, r=lqd

3b0df8c

Fix typo in uint_macros.rs

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 18, 2024

bors merged commit 52890e8 into rust-lang:master Dec 18, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Dec 18, 2024

bors mentioned this pull request Dec 18, 2024

remove support for the (unstable) #[start] attribute #134299

Merged

matthiaskrgr deleted the rollup-grmmmx2 branch January 25, 2025 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #134439

Rollup of 7 pull requests #134439

matthiaskrgr commented Dec 17, 2024

matthiaskrgr commented Dec 17, 2024

bors commented Dec 17, 2024

bors commented Dec 18, 2024

bors commented Dec 18, 2024

rust-timer commented Dec 18, 2024

Rollup of 7 pull requests #134439

Rollup of 7 pull requests #134439

Conversation

matthiaskrgr commented Dec 17, 2024

matthiaskrgr commented Dec 17, 2024

bors commented Dec 17, 2024

bors commented Dec 18, 2024

bors commented Dec 18, 2024

rust-timer commented Dec 18, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size