libsyntax: update helper to stringify TyU* and TyI* to take value presence into account. #13452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,9 +131,9 @@ pub fn is_path(e: @Expr) -> bool { | |||
| return match e.node { ExprPath(_) => true, _ => false }; | |||
| } | |||
|
|
|||
| pub fn int_ty_to_str(t: IntTy) -> ~str { | |||
| pub fn int_ty_to_str(t: IntTy, v: bool) -> ~str { | |||
There was a problem hiding this comment.
True if you're going to print it alongside a value, false if not.
e.g. we want 7u8 but not 7uint
Want a doc, or a better name? I guess an Option param would be clearer?
There was a problem hiding this comment.
A doc & a better name would be nice. :)
Could also be an enum like enum IntStrFormat { IntStrValue, IntStrType }.
|
Removed |
|
Looks good to me! Could you squash the two commits together? |
…unt having a value. Fixes rust-lang#13359.
|
@alexcrichton done. |
bors
added a commit
that referenced
this pull request
Apr 13, 2014
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Jan 9, 2023
…saturating, r=Veykril add wrapping/checked/saturating assist This addresses rust-lang#13452 I'm not sure about the structure of the code. I'm not sure if it needs to be 3 separate assists, and if that means it needs to be in 3 separate files as well. Most of the logic is in `util.rs`, which feels funny to me, but there seems to be a pattern of 1 assist per file, and this seems better than duplicating the logic. Let me know if anything needs changes 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13359.