Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests/ui/backtrace/std-backtrace.rs on MSVC. #134736

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Run tests/ui/backtrace/std-backtrace.rs on MSVC. #134736

merged 1 commit into from
Dec 25, 2024

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 24, 2024 •
edited by jieyouxu
Loading

The original PR which disabled these, #62897, only mentions them being broken on i686. let's still make sure the rest of windows is supported. Let's see if we can enable this for msvc now (32-bit and 64-bit).

r? @jieyouxu

try-job: x86_64-msvc
try-job: i686-msvc
try-job: i686-mingw
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
try-job: dist-x86_64-msvc
try-job: dist-i686-msvc

@jyn514
Copy link
Member Author

jyn514 commented Dec 24, 2024

@bors try

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 24, 2024
@bors
Copy link
Contributor

bors commented Dec 24, 2024

@jyn514: 🔑 Insufficient privileges: not in try users

@workingjubilee
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Dec 24, 2024

⌛ Trying commit 486135d with merge 6b5fe94...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2024
@bors
Auto merge of rust-lang#134736 - jyn514:msvc-backtraces, r=<try>
6b5fe94 
Run `tests/ui/backtrace/std-backtrace.rs` on MSVC.

the original PR which disabled these, rust-lang#62897, only mentions them being broken on i686. let's still make sure the rest of windows is supported.

r? `@jieyouxu`

try-job: x86_64-msvc
@ChrisDenton
Copy link
Member

Maybe also test i686-msvc? Backtrace without debug info will be screwy but we have debug info in CI nowadays iirc.

@bors
Copy link
Contributor

bors commented Dec 24, 2024

☀️ Try build successful - checks-actions
Build commit: 6b5fe94 (6b5fe94f03f0a251a04ace5ac2a32fc7193a9d61)

@workingjubilee
Copy link
Member

added all relevant Windows jobs I am aware of

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 25, 2024
@bors
Auto merge of rust-lang#134736 - jyn514:msvc-backtraces, r=<try>
fb6391c 
Run `tests/ui/backtrace/std-backtrace.rs` on MSVC.

the original PR which disabled these, rust-lang#62897, only mentions them being broken on i686. let's still make sure the rest of windows is supported.

r? `@jieyouxu`

try-job: x86_64-msvc
try-job: i686-msvc
try-job: i686-mingw
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@bors
Copy link
Contributor

bors commented Dec 25, 2024

⌛ Trying commit 486135d with merge fb6391c...

@bors
Copy link
Contributor

bors commented Dec 25, 2024

☀️ Try build successful - checks-actions
Build commit: fb6391c (fb6391c814b1e21f7e4831823cd38650a27f1828)

@workingjubilee
Copy link
Member

oh I suppose it would need the ignore string removed also

@jieyouxu

This comment was marked as resolved.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 25, 2024
@jieyouxu
Copy link
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 25, 2024
@bors
Auto merge of rust-lang#134736 - jyn514:msvc-backtraces, r=<try>
f8dbb39 
Run `tests/ui/backtrace/std-backtrace.rs` on MSVC.

the original PR which disabled these, rust-lang#62897, only mentions them being broken on i686. let's still make sure the rest of windows is supported.

r? `@jieyouxu`

try-job: x86_64-msvc
try-job: i686-msvc
try-job: i686-mingw
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
try-job: dist-x86_64-msvc
try-job: dist-i686-msvc
@bors
Copy link
Contributor

bors commented Dec 25, 2024

⌛ Trying commit b826a9d with merge f8dbb39...

@bors
Copy link
Contributor

bors commented Dec 25, 2024

☀️ Try build successful - checks-actions
Build commit: f8dbb39 (f8dbb39ffa3061d3b46a010dda37b47ea09e2719)

@jyn514 @jieyouxu
Run tests/ui/backtrace/std-backtrace.rs on MSVC.
c880e8b 
The original PR which disabled these only mentions them being broken on
i686 msvc. Let's try to see if we can reenable this test for msvc (both
32-bit and 64-bit).
@jieyouxu
Copy link
Member

Since it's just removing //@ ignore-msvc, and the try jobs seem to come back green, I just pushed to @jyn514's branch to remove the line. Let's see if this works in full CI.

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Dec 25, 2024

📌 Commit c880e8b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2024
@bors
Copy link
Contributor

bors commented Dec 25, 2024

⌛ Testing commit c880e8b with merge 97a56fb...

@bors
Copy link
Contributor

bors commented Dec 25, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 97a56fb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2024
@bors bors merged commit 97a56fb into rust-lang:master Dec 25, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 25, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (97a56fb): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.0% [-5.0%, -5.0%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.674s -> 764.158s (-0.07%)
Artifact size: 330.52 MiB -> 330.54 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jyn514 @bors @workingjubilee @ChrisDenton @jieyouxu @rust-timer @rustbot