Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it-self → itself, build-system → build system, type-alias → type alias #135285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

it-self → itself, build-system → build system, type-alias → type alias #135285

wants to merge 1 commit into from
+4 −4

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Jan 9, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

Some changes occurred in src/doc/rustc/src/check-cfg.md

cc @Urgau

Some changes occurred in cfg and check-cfg configuration

cc @Urgau

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 9, 2025

📌 Commit 5f76a17 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2025
@bors
Copy link
Contributor

bors commented Jan 9, 2025

☔ The latest upstream changes (presumably #135286) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 9, 2025
cramertj
cramertj reviewed Jan 10, 2025
View reviewed changes
src/doc/rustc/src/json.md Outdated Show resolved Hide resolved
@tbu-
Copy link
Contributor Author

tbu- commented Jan 27, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2025
workingjubilee
workingjubilee reviewed Jan 27, 2025
View reviewed changes
src/doc/rustc/src/platform-support/unknown-uefi.md
@@ -116,7 +116,7 @@ There are 3 common ways to compile native C code for UEFI targets:
- Use the official SDK by Intel:
[Tianocore/EDK2](https://github.com/tianocore/edk2). This supports a
multitude of platforms, comes with the full specification transposed into C,
lots of examples and build-system integrations. This is also the only
lots of examples and build system integrations. This is also the only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually correct usage of the hyphen, thus this recommended edit is incorrect. It is an example that follows the model of how deep-sea fish is written. There, "deep sea" becomes a modifier to "fish". Here, "build system" becomes a modifier to "integrations".

Suggested change
lots of examples and build system integrations. This is also the only
lots of examples and build-system integrations. This is also the only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

@workingjubilee workingjubilee workingjubilee left review comments

@cramertj cramertj cramertj left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tbu- @rustbot @GuillaumeGomez @bors @cramertj @workingjubilee @Noratrieb