ci: mirror ubuntu:22.04 to ghcr.io #135574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
marcoieni
commented
Jan 16, 2025
Kobzol
reviewed
Jan 16, 2025
marcoieni
force-pushed
the
docker-ghcr-mirror
branch
from
e61ea63 to
f5fe0a0
Compare
|
Looks good, thanks! I guess as usually with privileged GH actions, the only way to try it is to merge and see what happens :) @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134754 (Implement `use` associated items of traits) - rust-lang#135481 (coverage: Completely overhaul counter assignment, using node-flow graphs) - rust-lang#135504 (Allow coercing safe-to-call target_feature functions to safe fn pointers) - rust-lang#135561 (Update docs for `-Clink-dead-code` to discourage its use) - rust-lang#135574 (ci: mirror ubuntu:22.04 to ghcr.io) - rust-lang#135585 (resolve symlinks of LLVM tool binaries before copying them) - rust-lang#135588 (Add license-metadata.json to rustc-src tarball.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 17, 2025
Rollup merge of rust-lang#135574 - marcoieni:docker-ghcr-mirror, r=Kobzol ci: mirror ubuntu:22.04 to ghcr.io
|
I manually ran this, but it didn't work. |
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mirrors the
ubuntu:22.04image from DockerHub to ghcr.io.Tested here. In my repository, I tried pushing the ubuntu 18.10 image, which you can see it was pushed here.
Why is this needed
The PR job mingw-check-tidy always downloads the base layer from DockerHub, while the other jobs rely on the cache to download the base layer.
To avoid the risk of being rate limited by DockerHub, we want to download the base layer from ghcr.io, which doesn't have rate limits on pulls.
Agreed in zulip.
Next steps
Once this workflow runs, we can edit the
mingw-check-tidyDockerfile to use it.Related to rust-lang/infra-team#176
r? @Kobzol