Fix ICE in resolving associated items as non-bindings #135663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 18, 2025
…errors Fix ICE in resolving associated items as non-bindings Fixes rust-lang#135614 so that imported associated functions of traits can be shadowed by local bindings and associated constants of traits can be used in patterns.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135616 (CI: split i686-msvc job to two free runners) - rust-lang#135623 (ci: use ghcr ubuntu image for mingw-check-tidy) - rust-lang#135640 (Drop MIPS glibc 2.23 patches that reside in crosstool-ng now) - rust-lang#135663 (Fix ICE in resolving associated items as non-bindings) - rust-lang#135677 (Small `rustc_resolve` cleanups) - rust-lang#135680 (coverage: Clean up a few things after the counters overhaul) - rust-lang#135697 (Get rid of `ToPolyTraitRef`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#135616 (CI: split i686-msvc job to two free runners) - rust-lang#135623 (ci: use ghcr ubuntu image for mingw-check-tidy) - rust-lang#135640 (Drop MIPS glibc 2.23 patches that reside in crosstool-ng now) - rust-lang#135663 (Fix ICE in resolving associated items as non-bindings) - rust-lang#135680 (coverage: Clean up a few things after the counters overhaul) - rust-lang#135697 (Get rid of `ToPolyTraitRef`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2025
Rollup merge of rust-lang#135663 - frank-king:fix/135614, r=compiler-errors Fix ICE in resolving associated items as non-bindings Fixes rust-lang#135614 so that imported associated functions of traits can be shadowed by local bindings and associated constants of traits can be used in patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135614 so that imported associated functions of traits can be shadowed by local bindings and associated constants of traits can be used in patterns.