Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SIMD codegen tests on LLVM 20 #136134

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix SIMD codegen tests on LLVM 20 #136134

merged 1 commit into from
Jan 29, 2025

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Jan 27, 2025 •
edited
Loading

The splat constants are printed differently on LLVM 20.

@nikic
Fix SIMD codegen tests on LLVM 20
f895e31 
The splat contents are printed differently on LLVM 20.
@nikic nikic added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Jan 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2025
@nikic nikic mentioned this pull request Jan 27, 2025
Open
6 tasks
@zmodem
Copy link
Contributor

zmodem commented Jan 27, 2025

Thanks for fixing! (The previous instance was 0e58f1c)

@jhorstmann
Copy link
Contributor

Thanks, and sorry for not testing this combination. For reference, those tests were adjusted in #104693.

@Urgau
Copy link
Member

Urgau commented Jan 27, 2025

r? Urgau
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 27, 2025

📌 Commit f895e31 has been approved by Urgau

It is now in the queue for this repository.

@rustbot rustbot assigned Urgau and unassigned Mark-Simulacrum Jan 27, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025
@fmease fmease mentioned this pull request Jan 29, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
@bors
Auto merge of rust-lang#136227 - fmease:rollup-ewpvznh, r=fmease
e384432 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#136121 (Deduplicate operand creation between scalars, non-scalars and string patterns)
 - rust-lang#136134 (Fix SIMD codegen tests on LLVM 20)
 - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests)
 - rust-lang#136161 (rustdoc: add nobuild typescript checking to our JS)
 - rust-lang#136166 (interpret: is_alloc_live: check global allocs last)
 - rust-lang#136168 (GCI: Don't try to eval / collect mono items inside overly generic free const items)
 - rust-lang#136170 (Reject unsound toggling of Arm atomics-32 target feature)
 - rust-lang#136176 (Render pattern types nicely in mir dumps)
 - rust-lang#136186 (uefi: process: Fix args)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
@bors
Auto merge of rust-lang#136227 - fmease:rollup-ewpvznh, r=fmease
a1d7676 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#136121 (Deduplicate operand creation between scalars, non-scalars and string patterns)
 - rust-lang#136134 (Fix SIMD codegen tests on LLVM 20)
 - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests)
 - rust-lang#136161 (rustdoc: add nobuild typescript checking to our JS)
 - rust-lang#136166 (interpret: is_alloc_live: check global allocs last)
 - rust-lang#136168 (GCI: Don't try to eval / collect mono items inside overly generic free const items)
 - rust-lang#136170 (Reject unsound toggling of Arm atomics-32 target feature)
 - rust-lang#136176 (Render pattern types nicely in mir dumps)
 - rust-lang#136186 (uefi: process: Fix args)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 01f1dab into rust-lang:master Jan 29, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 29, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
@rust-timer
Unrolled build for rust-lang#136134
c5463a6 
Rollup merge of rust-lang#136134 - nikic:llvm-20-simd-tests, r=Urgau

Fix SIMD codegen tests on LLVM 20

The splat constants are printed differently on LLVM 20.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
@bors
Auto merge of rust-lang#135763 - nikic:llvm-20, r=<try>
93cf5c1 
Update to LLVM 20

LLVM 20 GA is scheduled for March 11th. Rust 1.86 will be stable on April 3rd.

* [x] rust-lang#135764
* [x] rust-lang#136134
* [x] rust-lang/compiler-builtins#752
* [ ] Update compiler-builtins

Tested: arm-android, test-various, x86_64-rust-for-linux, x86_64-fuchsia, dist-various-1, dist-various-2, dist-s390x-linux, dist-riscv64-linux, dist-loongarch64-musl

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
try-job: dist-aarch64-linux
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
@bors
Auto merge of rust-lang#135763 - nikic:llvm-20, r=<try>
92ffaa8 
Update to LLVM 20

LLVM 20 GA is scheduled for March 11th. Rust 1.86 will be stable on April 3rd.

* [x] rust-lang#135764
* [x] rust-lang#136134
* [x] rust-lang/compiler-builtins#752
* [ ] Update compiler-builtins

Tested: arm-android, test-various, x86_64-rust-for-linux, x86_64-fuchsia, dist-various-1, dist-various-2, dist-s390x-linux, dist-riscv64-linux, dist-loongarch64-musl

try-job: dist-x86_64-apple
try-job: dist-apple-various
try-job: x86_64-apple-1
try-job: x86_64-apple-2
try-job: dist-aarch64-apple
try-job: aarch64-apple
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
@bors
Auto merge of rust-lang#135763 - nikic:llvm-20, r=<try>
6ff8ac7 
Update to LLVM 20

LLVM 20 GA is scheduled for March 11th. Rust 1.86 will be stable on April 3rd.

* [x] rust-lang#135764
* [x] rust-lang#136134
* [x] rust-lang/compiler-builtins#752
* [ ] Update compiler-builtins

Tested: arm-android, test-various, x86_64-rust-for-linux, x86_64-fuchsia, dist-various-1, dist-various-2, dist-s390x-linux, dist-riscv64-linux, dist-loongarch64-musl

try-job: i686-mingw
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
try-job: dist-i686-mingw
try-job: dist-x86_64-mingw
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
@bors
Auto merge of rust-lang#135763 - nikic:llvm-20, r=<try>
2c240fb 
Update to LLVM 20

LLVM 20 GA is scheduled for March 11th. Rust 1.86 will be stable on April 3rd.

* [x] rust-lang#135764
* [x] rust-lang#136134
* [x] rust-lang/compiler-builtins#752
* [ ] Update compiler-builtins

Tested: arm-android, test-various, x86_64-rust-for-linux, x86_64-fuchsia, dist-various-1, dist-various-2, dist-s390x-linux, dist-riscv64-linux, dist-loongarch64-musl

try-job: i686-mingw
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
try-job: dist-i686-mingw
try-job: dist-x86_64-mingw
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2025
@bors
Auto merge of rust-lang#135763 - nikic:llvm-20, r=<try>
a093dde 
Update to LLVM 20

LLVM 20 GA is scheduled for March 11th. Rust 1.86 will be stable on April 3rd.

* [x] rust-lang#135764
* [x] rust-lang#136134
* [x] rust-lang/compiler-builtins#752
* [ ] Update compiler-builtins

Tested: host-x86_64, host-aarch64

try-job: i686-mingw
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
try-job: dist-i686-mingw
try-job: dist-x86_64-mingw
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2025
@bors
Auto merge of rust-lang#135763 - nikic:llvm-20, r=<try>
23c742f 
Update to LLVM 20

LLVM 20 GA is scheduled for March 11th. Rust 1.86 will be stable on April 3rd.

* [x] rust-lang#135764
* [x] rust-lang#136134
* [x] rust-lang/compiler-builtins#752
* [ ] llvm/llvm-project#125287
* [ ] Update compiler-builtins

Tested: host-x86_64, host-aarch64, mingw

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: dist-x86_64-msvc
try-job: dist-i686-msvc
try-job: dist-aarch64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2025
@bors
Auto merge of rust-lang#135763 - nikic:llvm-20, r=<try>
ad23dfe 
Update to LLVM 20

LLVM 20 GA is scheduled for March 11th. Rust 1.86 will be stable on April 3rd.

* [x] rust-lang#135764
* [x] rust-lang#136134
* [x] rust-lang/compiler-builtins#752
* [ ] llvm/llvm-project#125287
* [ ] Update compiler-builtins (blocked on rust-lang#135501)

Tested: host-x86_64, host-aarch64, apple, mingw

try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: dist-aarch64-msvc
try-job: x86_64-msvc-ext1
try-job: x86_64-msvc-ext2
try-job: x86_64-msvc-ext3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
7 participants
@nikic @rustbot @zmodem @jhorstmann @Urgau @bors @Mark-Simulacrum