Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override build profile for bootstrap tests #136157

Merged
merged 1 commit into from
Jan 31, 2025
Merged

override build profile for bootstrap tests #136157

merged 1 commit into from
Jan 31, 2025
+23 −8

Conversation

onur-ozkan
Copy link
Member

Using the release profile for bootstrap self tests puts too much load on the CPU and makes it quite hot on x test bootstrap invocation for no good reason. It also makes the compilation take longer than usual (see #136048 (comment)). This change turns off the release flag for bootstrap self tests.

@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 27, 2025
@Kobzol
Copy link
Contributor

Kobzol commented Jan 27, 2025

This is a nice API that we can use to selectively force debug compilation for selected steps. You can r=me after CI is green :)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan onur-ozkan force-pushed the override-release-profile branch 2 times, most recently from 16f9a16 to e5778f0 Compare January 28, 2025 14:31
@onur-ozkan
Copy link
Member Author

@rustbot author (I don't like the current approach and will improve this further)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2025
@onur-ozkan
override build profile for bootstrap tests
869bc2f 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the override-release-profile branch from e5778f0 to 869bc2f Compare January 29, 2025 11:49
@onur-ozkan
Copy link
Member Author

Looks much better now (see the diff).

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2025
@Kobzol
Copy link
Contributor

Kobzol commented Jan 29, 2025

The clean command will no longer use --release after this, but that's probably not very important.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 29, 2025

📌 Commit 869bc2f has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2025
@onur-ozkan
Copy link
Member Author

onur-ozkan commented Jan 30, 2025 •
edited
Loading

Using precompiled LLVM seems to cause this problem. You can set NO_DOWNLOAD_CI_LLVM=1 as a workaround until we fix the bootstrapping issue.

Oops, wrong page 😄

@matthiaskrgr matthiaskrgr mentioned this pull request Jan 30, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
@bors
Auto merge of rust-lang#136318 - matthiaskrgr:rollup-a159mzo, r=matth…
6c1d960 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#135026 (Cast global variables to default address space)
 - rust-lang#135475 (uefi: Implement path)
 - rust-lang#135852 (Add `AsyncFn*` to `core` prelude)
 - rust-lang#136004 (tests: Skip const OOM tests on aarch64-unknown-linux-gnu)
 - rust-lang#136157 (override build profile for bootstrap tests)
 - rust-lang#136180 (Introduce a wrapper for "typed valtrees" and properly check the type before extracting the value)
 - rust-lang#136256 (Add release notes for 1.84.1)
 - rust-lang#136271 (Remove minor future footgun in `impl Debug for MaybeUninit`)
 - rust-lang#136288 (Improve documentation for file locking)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6c9c698 into rust-lang:master Jan 31, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 31, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2025
@rust-timer
Unrolled build for rust-lang#136157
b85cb3c 
Rollup merge of rust-lang#136157 - onur-ozkan:override-release-profile, r=Kobzol

override build profile for bootstrap tests

Using the release profile for bootstrap self tests puts too much load on the CPU and makes it quite hot on `x test bootstrap` invocation for no good reason. It also makes the compilation take longer than usual (see rust-lang#136048 (comment)). This change turns off the release flag for bootstrap self tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@onur-ozkan @rustbot @Kobzol @rust-log-analyzer @bors @Mark-Simulacrum