implement inherent str constructors #136517
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jhpratt (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
i am not quite sure how this failure is in any way related to this pr, since i am only touching inherent functions on str? but sure.
m4rch3n1ng
force-pushed
the
inherent-str-constructors
branch
from
9cedf45 to
15adc38
Compare
That can be done in a separate PR if you wish!
The attributes are correct. The compiler will (thankfully!) complain if they're clearly wrong, but there are edge cases that reviewers can keep an eye out for if you're ever not sure. As to why the mutable version is not const stable, that's a great question. I asked in the tracking issue, so the team should look at it soon-ish.
Probably, but don't worry about it. I'll ping @estebank to see if there's anything that can be done here (ideally for the general case, as there's a number of things like this). Thank you for doing this! It looks good to me, so merging 🙂 @bors r+ |
bors
added
S-waiting-on-bors
Rollup of 12 pull requests Successful merges: - rust-lang#132547 (cg_gcc: Directly use rustc_abi instead of reexports) - rust-lang#135572 (tests: Port `split-debuginfo` to rmake.rs) - rust-lang#135964 (Make cenum_impl_drop_cast a hard error) - rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe}) - rust-lang#136304 (Reject negative literals for unsigned or char types in pattern ranges and literals) - rust-lang#136418 (uefi: process: Add support for command environment variables) - rust-lang#136449 (std: move network code into `sys`) - rust-lang#136517 (implement inherent str constructors) - rust-lang#136536 (Rename and Move some UI tests to more suitable subdirs) - rust-lang#136537 (Update `compiler-builtins` to 0.1.145) - rust-lang#136555 (Rename `slice::take...` methods to `split_off...`) - rust-lang#136567 (Arbitrary self types v2: recursion test) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 12 pull requests Successful merges: - rust-lang#132547 (cg_gcc: Directly use rustc_abi instead of reexports) - rust-lang#135572 (tests: Port `split-debuginfo` to rmake.rs) - rust-lang#135964 (Make cenum_impl_drop_cast a hard error) - rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe}) - rust-lang#136304 (Reject negative literals for unsigned or char types in pattern ranges and literals) - rust-lang#136418 (uefi: process: Add support for command environment variables) - rust-lang#136449 (std: move network code into `sys`) - rust-lang#136517 (implement inherent str constructors) - rust-lang#136536 (Rename and Move some UI tests to more suitable subdirs) - rust-lang#136537 (Update `compiler-builtins` to 0.1.145) - rust-lang#136555 (Rename `slice::take...` methods to `split_off...`) - rust-lang#136567 (Arbitrary self types v2: recursion test) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#136517 - m4rch3n1ng:inherent-str-constructors, r=jhpratt implement inherent str constructors implement rust-lang#131114 this implements - str::from_utf8 - str::from_utf8_mut - str::from_utf8_unchecked - str::from_utf8_unchecked_mut i left `std::str::from_raw_parts` and `std::str::from_raw_parts_mut` out of this as those are unstable and were not mentioned by the tracking issue or the original pull request, but i can add those here as well. i was also unsure of what to do with the `rustc_const_(un)stable` attributes: i removed the `#[rustc_const_stable]` attribute from `str::from_utf8`, `str::from_utf8_unchecked` and `str::from_utf8_unchecked_mut`, and left the`#[rust_const_unstable]` in `str::from_utf8_mut` (btw why is that one not const stable yet with rust-lang#57349 merged?). is there a way to redirect users to the stable `std::str::from_utf8` instead of only saying "hey this is unstable"? for now i just removed the check for `str::from_utf8` in the test in `tests/ui/suggestions/suggest-std-when-using-type.rs`.
implement #131114
this implements
i left
std::str::from_raw_partsandstd::str::from_raw_parts_mutout of this as those are unstable and were not mentioned by the tracking issue or the original pull request, but i can add those here as well.i was also unsure of what to do with the
rustc_const_(un)stableattributes: i removed the#[rustc_const_stable]attribute fromstr::from_utf8,str::from_utf8_uncheckedandstr::from_utf8_unchecked_mut, and left the#[rust_const_unstable]instr::from_utf8_mut(btw why is that one not const stable yet with #57349 merged?).is there a way to redirect users to the stable
std::str::from_utf8instead of only saying "hey this is unstable"?for now i just removed the check for
str::from_utf8in the test intests/ui/suggestions/suggest-std-when-using-type.rs.