-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
librustc: Remove ~"string"
and &"string"
from the language
#13877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
May 1, 2014
These commits should've had a [breaking-change] annotation. |
renato-zannon
added a commit
to renato-zannon/rust-bindgen
that referenced
this pull request
May 2, 2014
[~"string" and &"string" literals are gone](rust-lang/rust#13877), and were replaced by "string".to_owned() and just "string", respectively. This commit was made by a simple `sed` to convert the existing instances of ~"string" on the codebase. For reference, the command used was this: sed -e 's/~\("[^"]*"\)/\1.to_owned()/g' -i *.rs That wouldn't work if for strings that contain the `\"` escape in them, but this codebase had none. Similar work is likely to be necessary after [~T is substituted by Box<T>](rust-lang/rust#13885).
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Jan 9, 2023
…elude, r=Veykril fix: prefix prelude items whose name collides in current scope Fixes rust-lang#13873 When we assemble path for prelude items whose name collides with other item in scope, we should always prefix it with module paths.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 9, 2025
This PR just makes sure that we exit the function before getting an ICE and adds a regression test. Related to rust-lang#12979. We would need to keep researching the issue, but as the ICEing code isn't that complicated, getting a hotfix into nightly is urgent. changelog:[`borrow_interior_mutable_const`] Fix ICE rust-lang#12979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.